Skip to content

test: update expected error message for macOS - #57742

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-macos-error
Apr 6, 2025
Merged

test: update expected error message for macOS#57742
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-macos-error

Conversation

@aduh95

@aduh95aduh95 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

It started failing on my machine recently, if I have to guess I'd say it's probably related to the recent 15.4 macOS update.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 4, 2025
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66024/

@codecov

codecovBot commented Apr 4, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (87f8d3c) to head (cc64ff7).
Report is 397 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57742 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01% 
==========================================
Files 630 630 Lines 184990 184990 Branches 36218 36209 -9 ==========================================
+ Hits 166948 166969 +21 + Misses 11002 10995 -7 + Partials 7040 7026 -14

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66030/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 33f6e1e into nodejs:mainApr 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in 33f6e1e

@aduh95
aduh95 deleted the fix-macos-error branch April 6, 2025 15:35
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95@RafaelGSS
test: update expected error message for macOS
39e38cd
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95@RafaelGSS
test: update expected error message for macOS
9af8b92
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
test: update expected error message for macOS
eba7c76
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95@RafaelGSS
test: update expected error message for macOS
b8ec2af
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
test: update expected error message for macOS
1548498
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
test: update expected error message for macOS
87ecfe8
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
test: update expected error message for macOS
a3be0df
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@aduh95@marco-ippolito
test: update expected error message for macOS
c9c0be5
PR-URL: #57742
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 5, 2025
Merged
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@jasnell@lpinca@richardlau@marco-ippolito