http: improve performance by removing async_hooks

[JonasBa]

Pending benchmarks, but this should improve http request performance.

Github search results for HTTPIncomingMessage and HTTPClientRequest

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[mcollina]

Pending positive benchmarks, I’m in favor of this change as the http parser does not have inherent asynchronous behavior and it’s all sync.

[Flarna]

HTTP parser instances are reused between HTTP requests (there is a pool of them). in contrast to parser HTTP requests are async and each HTTP request holds a parser.

There are some tests deleted in this PR which verify that each HTTP request is seen as an unique async resource.

AsyncLocalStore is/was built on top of async hooks (get current resource), as a result test coverage for ALS is quite limited because of this..

Therefore I fear that this is quite breaking for ALS users. I recommend to add tests similar to the deleted ones but using AsyncLocalStore API to ensure nothing is broken because of this removal.

[anonrig]

I don't think we need this. We just shouldn't throw if the previous js callback throws, but we shouldn't stop the flow when an error is thrown on the user handler.

[codecov]

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (1123585) to head (ee036b5).
Report is 169 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_http_parser.cc	60.00%	4 Missing and 8 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #57746 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.01% 
==========================================
Files 630 630 Lines 185055 186045 +990 Branches 36216 36455 +239 ==========================================
+ Hits 166975 167905 +930 + Misses 11042 10995 -47 - Partials 7038 7145 +107 

Files with missing lines	Coverage Δ
lib/_http_client.js	97.97% <ø> (-0.02%)	⬇️
lib/_http_common.js	100.00% <ø> (ø)
lib/_http_server.js	96.98% <100.00%> (-0.01%)	⬇️
src/node_http_parser.cc	82.59% <60.00%> (-0.44%)	⬇️

... and 120 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

The HTTPServerAsyncResource class can now be removed I believe.

[JonasBa]

Sorry everyone, looks like the lack of sleep as a new parent caused me to not even notice that I pushed this from my main fork branch. I'll close this PR and reopen it on a proper branch, with a link to the discussions here.