Skip to content

doc: explicitly state that corepack will be removed in v25+ - #57747

Merged
nodejs-github-bot merged 2 commits into
mainfrom
corepack-removal-version
Apr 7, 2025
Merged

doc: explicitly state that corepack will be removed in v25+#57747
nodejs-github-bot merged 2 commits into
mainfrom
corepack-removal-version

Conversation

@trivikr

@trivikrtrivikr commented Apr 4, 2025

Copy link
Copy Markdown
Member

The generic "future versions of" Node.js is causing a confusion among corepack users.
Example nodejs/corepack#688 (comment)

This PR explicitly changes it to v25+ as agreed in TSC vote in nodejs/TSC#1697 (comment)

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2025
@trivikrtrivikr mentioned this pull request Apr 4, 2025
Closed
@trivikrtrivikr changed the title docs: explicitly state that corepack will be removed in v25+doc: explicitly state that corepack will be removed in v25+Apr 4, 2025
@MikeMcC399

MikeMcC399 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

@trivikr

Thank you for picking this up! As you know, I unsuccessfully raised it in #57708 (comment). Admittedly there were multiple issues I raised in that one issue.

It looks like you'll need to update your commit though, to change docs: to doc:

image

@trivikr
trivikrforce-pushed the corepack-removal-version branch from 683c103 to 1a83409CompareApril 4, 2025 16:32
@trivikr

trivikr commented Apr 4, 2025

Copy link
Copy Markdown
MemberAuthor

It looks like you'll need to update your commit though, to change docs: to doc:

Thanks! I force-pushed in 1a83409

MikeMcC399
MikeMcC399 reviewed Apr 4, 2025
View reviewed changes
Comment threaddoc/api/corepack.md Outdated
@trivikr
trivikr requested review from MikeMcC399 and aduh95 and removed request for MikeMcC399April 4, 2025 16:46
styfle
styfle approved these changes Apr 4, 2025
View reviewed changes

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarity!

MikeMcC399
MikeMcC399 reviewed Apr 5, 2025
View reviewed changes
Comment threaddoc/api/corepack.md
Despite Corepack being distributed with default installs of Node.js, the package
managers managed by Corepack are not part of the Node.js distribution, and
Corepack itself will no longer be distributed with future versions of Node.js.
Corepack itself will no longer be distributed with Node.js 25+.

@MikeMcC399MikeMcC399Apr 5, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr

I'll just remove the v as of now, and will wait for input from other collaborators

Using the notation from https://github.com/nodejs/release including the use of the term "release line" to refer to all releases with same major version number:

Suggested change
Corepack itself will no longer be distributed with Node.js 25+.
Corepack itself will no longer be distributed with release lines Node.js 25 and above.

You could also write "releases Node.js >=25.0.0" using semver notation.

@MikeMcC399MikeMcC399 mentioned this pull request Apr 6, 2025
Closed
@trivikrtrivikr self-assigned this Apr 7, 2025
@trivikrtrivikr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b6a10f7 into mainApr 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in b6a10f7

@nodejs-github-bot
nodejs-github-bot deleted the corepack-removal-version branch April 7, 2025 15:53
@trivikrtrivikr mentioned this pull request Apr 10, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@trivikr@RafaelGSS
doc: explicitly state that corepack will be removed in v25+
e5223d9
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@trivikr@RafaelGSS
doc: explicitly state that corepack will be removed in v25+
952a212
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@trivikr@aduh95
doc: explicitly state that corepack will be removed in v25+
5b79f16
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@trivikr@RafaelGSS
doc: explicitly state that corepack will be removed in v25+
bfaacea
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@trivikr@aduh95
doc: explicitly state that corepack will be removed in v25+
46d463b
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@trivikr@aduh95
doc: explicitly state that corepack will be removed in v25+
561a65f
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@trivikr@aduh95
doc: explicitly state that corepack will be removed in v25+
92428c2
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcC399MikeMcC399MikeMcC399 left review comments
@ljharbljharbljharb approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@gurgundaygurgundaygurgunday approved these changes
@aduh95aduh95Awaiting requested review from aduh95
+2 more reviewers
@styflestyflestyfle approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trivikrtrivikr

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@trivikr@MikeMcC399@nodejs-github-bot@ljharb@styfle@jasnell@lpinca@UlisesGascon@BridgeAR@RaisinTen@gurgunday@bjohansebas