Uh oh!
There was an error while loading. Please reload this page.
src: improve error handling in callback.cc - #57758
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups
aduh95
approved these changes
Apr 5, 2025
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Apr 6, 2025
jasnell added a commit
that referenced
this pull request
Apr 7, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
jasnell
commented
Apr 7, 2025
MemberAuthor
Landed in a5877d0 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit
that referenced
this pull request
May 6, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 14, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit
that referenced
this pull request
May 16, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit
that referenced
this pull request
May 17, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit
that referenced
this pull request
May 19, 2025
Avoiding use of v8 `Checked()` APIs where appropriate. Few other style cleanups PR-URL: #57758 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding use of v8
Checked()APIs where appropriate. Few other style cleanups