Uh oh!
There was an error while loading. Please reload this page.
lib: add defaultValue and name options to AsyncLocalStorage - #57766
Closed
jasnell wants to merge 2 commits into
Closed
lib: add defaultValue and name options to AsyncLocalStorage#57766jasnell wants to merge 2 commits into
jasnell wants to merge 2 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
mcollina
commented
Apr 5, 2025
Member
I don't think we should do this right now because the spec is still Stage 2, while AsyncLocalStorage is stable. Those fields could easily be scrapped/changed, and we would be stuck with them. |
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Apr 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jasnellforce-pushed
the
jasnell/asynclocalstorage-options
branch
from
April 6, 2025 03:34
0612c1f to
4cf070fCompareMemberAuthor
I wouldn't have opened the PR if I didn't think they were useful independently of the Specifically, if we were prematurely implementing |
jasnell
commented
Apr 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
jasnellforce-pushed
the
jasnell/asynclocalstorage-options
branch
from
April 6, 2025 04:15
4ef2590 to
3e68ac6CompareThe upcoming `AsyncContext` specification adds a default value and name
to async storage variables. This adds the same to `AsyncLocalStorage`
to promote closer alignment with the pending spec.
```js
const als = new AsyncLocalStorage({
name: 'foo',
defaultValue: 123,
});
console.log(als.name); // 'foo'
console.log(als.getStore()); // 123
```
Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.htmljasnellforce-pushed
the
jasnell/asynclocalstorage-options
branch
from
April 6, 2025 16:22
3e68ac6 to
69a25e2Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
legendecas
approved these changes
Apr 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
jasnell added a commit
that referenced
this pull request
Apr 7, 2025
The upcoming `AsyncContext` specification adds a default value and name
to async storage variables. This adds the same to `AsyncLocalStorage`
to promote closer alignment with the pending spec.
```js
const als = new AsyncLocalStorage({
name: 'foo',
defaultValue: 123,
});
console.log(als.name); // 'foo'
console.log(als.getStore()); // 123
```
Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.html
PR-URL: #57766
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>jasnell
commented
Apr 7, 2025
MemberAuthor
Landed in a369818 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
The upcoming `AsyncContext` specification adds a default value and name
to async storage variables. This adds the same to `AsyncLocalStorage`
to promote closer alignment with the pending spec.
```js
const als = new AsyncLocalStorage({
name: 'foo',
defaultValue: 123,
});
console.log(als.name); // 'foo'
console.log(als.getStore()); // 123
```
Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.html
PR-URL: #57766
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
The upcoming `AsyncContext` specification adds a default value and name
to async storage variables. This adds the same to `AsyncLocalStorage`
to promote closer alignment with the pending spec.
```js
const als = new AsyncLocalStorage({
name: 'foo',
defaultValue: 123,
});
console.log(als.name); // 'foo'
console.log(als.getStore()); // 123
```
Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.html
PR-URL: #57766
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>aduh95
commented
May 6, 2025
Contributor
Tests are not passing on v22.x-staging, this would require a manual backport if we want it on 22.x |
mcollina pushed a commit
to mcollina/node
that referenced
this pull request
Dec 12, 2025
The upcoming `AsyncContext` specification adds a default value and name
to async storage variables. This adds the same to `AsyncLocalStorage`
to promote closer alignment with the pending spec.
```js
const als = new AsyncLocalStorage({
name: 'foo',
defaultValue: 123,
});
console.log(als.name); // 'foo'
console.log(als.getStore()); // 123
```
Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.html
PR-URL: nodejs#57766
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming
AsyncContextspecification adds a default value and name to async storage variables. This adds the same toAsyncLocalStorageto promote closer alignment with the pending spec.Refs: https://github.com/tc39/proposal-async-context/blob/master/spec.html