Skip to content

src: improve error handling in node_env_var.cc - #57767

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:error-handling-cc
Apr 7, 2025
Merged

src: improve error handling in node_env_var.cc#57767
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:error-handling-cc

Conversation

@aduh95

@aduh95aduh95 commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 5, 2025
@codecov

codecovBot commented Apr 5, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (214e3d4) to head (ff56705).
Report is 24 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57767 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01% 
==========================================
Files 630 630 Lines 185204 185204 Branches 36296 36294 -2 ==========================================
+ Hits 167133 167158 +25 + Misses 11003 10990 -13 + Partials 7068 7056 -12
Files with missing linesCoverage Δ
src/node_env_var.cc83.23% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 6, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66077/ 💛

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 1540fc6 into nodejs:mainApr 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in 1540fc6

@aduh95
aduh95 deleted the error-handling-cc branch April 8, 2025 08:24
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95@RafaelGSS
src: improve error handling in node_env_var.cc
d48d24f
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95@RafaelGSS
src: improve error handling in node_env_var.cc
2b0f65e
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
src: improve error handling in node_env_var.cc
abe4bd7
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95@RafaelGSS
src: improve error handling in node_env_var.cc
310c6d0
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
src: improve error handling in node_env_var.cc
6625380
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
src: improve error handling in node_env_var.cc
79df31b
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
src: improve error handling in node_env_var.cc
4754c69
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@jasnell@targos@legendecas