Skip to content

doc: clarify Corepack removal in v25+ - #57813

Closed
trivikr wants to merge 4 commits into
mainfrom
trivikr/doc-corepack
Closed

doc: clarify Corepack removal in v25+#57813
trivikr wants to merge 4 commits into
mainfrom
trivikr/doc-corepack

Conversation

@trivikr

@trivikrtrivikr commented Apr 10, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Alternative to #57663

This preserves the existing documentation page for corepack which has backlinks from all over the internet.
It can be removed close to April 2028, after corepack is completely removed from all Node.js versions.

Refs:

@trivikrtrivikr added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 10, 2025
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2025
@trivikrtrivikr mentioned this pull request Apr 10, 2025
Merged
trivikr
trivikr commented Apr 10, 2025
View reviewed changes
Comment threaddoc/api/corepack.md Outdated
@trivikr
trivikr requested a review from aduh95April 10, 2025 04:53
MikeMcC399
MikeMcC399 reviewed Apr 10, 2025
View reviewed changes
Comment threaddoc/api/corepack.md Outdated
ljharb
ljharb approved these changes Apr 10, 2025
View reviewed changes

@ljharbljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the grammar suggestion

@trivikr
trivikr requested a review from ljharbApril 10, 2025 06:19
@aduh95

aduh95 commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

The commit message do not match our guidelines, the first word after the subsystem should be an imperative verb.

trivikrand others added 3 commits April 10, 2025 15:53
@trivikr
doc: clarify Corepack removal in v25+
91336b4
@trivikr
doc: explicitly mention v25+
7fa8646
@trivikr@MikeMcC399
doc: fix grammar nit
3b95127
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@trivikr
trivikrforce-pushed the trivikr/doc-corepack branch from f163dc7 to 3b95127CompareApril 10, 2025 15:54
@trivikrtrivikr changed the title doc: corepack no longer distributed in v25+doc: clarify Corepack removal in v25+Apr 10, 2025
@trivikr

trivikr commented Apr 10, 2025

Copy link
Copy Markdown
MemberAuthor

@aduh95 I've updated the first commit to use imperative verb after subsystem: doc: clarify Corepack removal in v25+

trivikr
trivikr commented Apr 10, 2025
View reviewed changes
Comment threaddoc/api/corepack.md Outdated
@trivikr

trivikr commented Apr 10, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Closing this PR, as the existing documentation can be edited better with highlight and call to action just like it's done for other modules for all Node.js versions. That PR is posted in #57825

@trivikrtrivikr closed this Apr 10, 2025
@trivikr
trivikr deleted the trivikr/doc-corepack branch April 10, 2025 17:52
@trivikr

trivikr commented Apr 10, 2025

Copy link
Copy Markdown
MemberAuthor

I'll post a new PR specific to v25.x after #57825 is merged.
There we can change the language to mark corepack as deprecated, just like we did in punycode.

@trivikr

trivikr commented Apr 14, 2025

Copy link
Copy Markdown
MemberAuthor

We're instead trying to enable redirect from corepack latest documentation in nodejs/nodejs.org#7643 (review)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcC399MikeMcC399MikeMcC399 left review comments
@lpincalpincalpinca approved these changes
@aduh95aduh95Awaiting requested review from aduh95
@ljharbljharbAwaiting requested review from ljharb

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trivikr@aduh95@ljharb@lpinca@MikeMcC399@nodejs-github-bot