Skip to content

src: enter and lock isolate properly in json parser - #57823

Closed
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:fix-json-parser
Closed

src: enter and lock isolate properly in json parser#57823
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:fix-json-parser

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Apr 10, 2025

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 10, 2025
@joyeecheungjoyeecheung mentioned this pull request Apr 10, 2025
Closed
@codecov

codecovBot commented Apr 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (8dce721) to head (2ed9171).
Report is 9 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57823 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01% 
==========================================
Files 630 630 Lines 185465 185470 +5 Branches 36368 36371 +3 ==========================================
- Hits 167362 167350 -12 - Misses 10999 11006 +7 - Partials 7104 7114 +10
Files with missing linesCoverage Δ
src/json_parser.cc80.00% <100.00%> (+1.00%)⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66193/ 💛

jasnell pushed a commit that referenced this pull request Apr 12, 2025
@joyeecheung@jasnell
src: enter and lock isolate properly in json parser
d0ce668
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@jasnell

jasnell commented Apr 12, 2025

Copy link
Copy Markdown
Member

Landed in d0ce668

@jasnelljasnell closed this Apr 12, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@joyeecheung@RafaelGSS
src: enter and lock isolate properly in json parser
b65f492
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@joyeecheung@RafaelGSS
src: enter and lock isolate properly in json parser
5e14fd1
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@joyeecheung@aduh95
src: enter and lock isolate properly in json parser
e2b0e7d
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@joyeecheung@aduh95
src: enter and lock isolate properly in json parser
68e1907
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@joyeecheung@RafaelGSS
src: enter and lock isolate properly in json parser
fa31bd5
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@joyeecheung@aduh95
src: enter and lock isolate properly in json parser
2a28e6d
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@joyeecheung@aduh95
src: enter and lock isolate properly in json parser
e6e7bcb
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@joyeecheung@aduh95
src: enter and lock isolate properly in json parser
dda6423
PR-URL: #57823
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@legendecaslegendecaslegendecas approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@nodejs-github-bot@jasnell@targos@legendecas@RaisinTen