src: fix typo in comments by geeksilva97 · Pull Request #57868 · nodejs/node

geeksilva97 · 2025-04-13T22:50:39Z

This PR fixes a typo in node_sqlite.cc file

nodejs-github-bot · 2025-04-13T22:50:44Z

Review requested:

@nodejs/sqlite

codecov · 2025-04-13T23:39:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (09ecd2e) to head (54433b0).
Report is 38 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #57868 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01% 
==========================================
Files 630 630 Lines 185502 185670 +168 Branches 36366 36401 +35 ==========================================
+ Hits 167402 167552 +150 + Misses 11000 10992 -8 - Partials 7100 7126 +26

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`80.49% <ø> (ø)`

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2025-04-14T12:52:42Z

I have a silly question. Do I need to run CI here?

cjihrig · 2025-04-14T12:59:35Z

Do I need to run CI here?

Yes, since this is a change to the source code.

geeksilva97 · 2025-04-14T13:00:13Z

Do I need to run CI here?
Yes, since this is a change to the source code.

great. ty

nodejs-github-bot · 2025-04-14T18:28:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66267/

nodejs-github-bot · 2025-04-15T22:53:25Z

Commit Queue failed

- Loading data for nodejs/node/pull/57868
✔ Done loading data for nodejs/node/pull/57868
----------------------------------- PR info ------------------------------------
Title src: fix typo in comments (#57868)
Author Edy Silva <edigleyssonsilva@gmail.com> (@geeksilva97)
Branch geeksilva97:fix-typo-in-comments -> nodejs:main
Labels c++, author ready, needs-ci, sqlite
Commits 1
- src: fix typo in comments
Committers 1
- Edy Silva <edigleyssonsilva@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 13 Apr 2025 22:50:39 GMT
✔ Approvals: 5
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763129313
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763291828
✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764259918
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764666235
✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/57868#pullrequestreview-2766864878
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2025-04-14T18:28:00Z: https://ci.nodejs.org/job/node-test-pull-request/66267/
- Querying data for job/node-test-pull-request/66267/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14480877191

nodejs-github-bot · 2025-04-18T17:58:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/57868
✔ Done loading data for nodejs/node/pull/57868
----------------------------------- PR info ------------------------------------
Title src: fix typo in comments (#57868)
Author Edy Silva <edigleyssonsilva@gmail.com> (@geeksilva97)
Branch geeksilva97:fix-typo-in-comments -> nodejs:main
Labels c++, author ready, needs-ci, sqlite
Commits 1
- src: fix typo in comments
Committers 1
- Edy Silva <edigleyssonsilva@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 13 Apr 2025 22:50:39 GMT
✔ Approvals: 6
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763129313
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763291828
✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764259918
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764666235
✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/57868#pullrequestreview-2766864878
✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/57868#pullrequestreview-2773217122
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2025-04-18T16:37:24Z: https://ci.nodejs.org/job/node-test-pull-request/66351/
- Querying data for job/node-test-pull-request/66351/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14539430804

nodejs-github-bot · 2025-04-18T18:21:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66352/

nodejs-github-bot · 2025-04-19T09:33:49Z

Landed in 63640eb

PR-URL: #57868 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

src: fix typo in comments
54433b0

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 13, 2025

RaisinTen approved these changes Apr 14, 2025
View reviewed changes

lpinca approved these changes Apr 14, 2025
View reviewed changes

cjihrig approved these changes Apr 14, 2025
View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025

This comment was marked as outdated.
Sign in to view

jasnell approved these changes Apr 14, 2025
View reviewed changes

jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 14, 2025

bjohansebas approved these changes Apr 14, 2025
View reviewed changes

Ayase-252 approved these changes Apr 15, 2025
View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 15, 2025

geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 16, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025

This comment was marked as outdated.
Sign in to view

himself65 approved these changes Apr 16, 2025
View reviewed changes

This comment was marked as outdated.
Sign in to view

geeksilva97 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 18, 2025

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 19, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025

nodejs-github-bot merged commit 63640eb into nodejs:mainApr 19, 2025

RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged

github-actionsBot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged

geeksilva97 deleted the fix-typo-in-comments branch May 20, 2025 00:46

ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed

Navigation Menu

Uh oh!

Uh oh!

src: fix typo in comments - #57868

src: fix typo in comments#57868
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
geeksilva97:fix-typo-in-comments

geeksilva97 commented Apr 13, 2025

Uh oh!

nodejs-github-bot commented Apr 13, 2025

Uh oh!

codecovBot commented Apr 13, 2025•
edited
Loading

Uh oh!

geeksilva97 commented Apr 14, 2025

Uh oh!

cjihrig commented Apr 14, 2025

Uh oh!

geeksilva97 commented Apr 14, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Apr 14, 2025

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

geeksilva97 commented Apr 13, 2025

Uh oh!

nodejs-github-bot commented Apr 13, 2025

Uh oh!

codecovBot commented Apr 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geeksilva97 commented Apr 14, 2025

Uh oh!

cjihrig commented Apr 14, 2025

Uh oh!

geeksilva97 commented Apr 14, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Apr 14, 2025

Uh oh!

nodejs-github-bot commented Apr 15, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecovBot commented Apr 13, 2025•
edited
Loading