Skip to content

assert: support Float16Array in loose deep equality checks - #57881

Merged
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
LiviaMedeiros:assert-deepequal-float16array
Apr 19, 2025
Merged

assert: support Float16Array in loose deep equality checks#57881
nodejs-github-bot merged 5 commits into
nodejs:mainfrom
LiviaMedeiros:assert-deepequal-float16array

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Apr 14, 2025

Copy link
Copy Markdown
Member

Depends on: #57879

@LiviaMedeirosLiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Apr 14, 2025
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 14, 2025
@LiviaMedeirosLiviaMedeiros added the assert Issues and PRs related to the assert subsystem. label Apr 14, 2025
BridgeAR
BridgeAR reviewed Apr 14, 2025
View reviewed changes
Comment threadlib/internal/util/comparisons.js Outdated
@LiviaMedeirosLiviaMedeiros added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 14, 2025
@LiviaMedeiros
LiviaMedeirosforce-pushed the assert-deepequal-float16array branch from 157b25b to 41b2697CompareApril 17, 2025 06:09
@LiviaMedeiros
LiviaMedeiros marked this pull request as ready for review April 17, 2025 06:14
@LiviaMedeirosLiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Apr 17, 2025
@codecov

codecovBot commented Apr 17, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e61937b) to head (a1c081f).
Report is 16 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57881 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01% 
==========================================
Files 630 630 Lines 185786 185790 +4 Branches 36426 36428 +2 ==========================================
+ Hits 167653 167679 +26 
Misses 11001 11001 + Partials 7132 7110 -22
Files with missing linesCoverage Δ
lib/internal/util/comparisons.js100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros
squash: fix test
a1c081f
Number.EPSILON < 2**-24
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66362/

@LiviaMedeirosLiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2025
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot
nodejs-github-bot merged commit afd318d into nodejs:mainApr 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

Landed in afd318d

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@LiviaMedeiros@RafaelGSS
assert: support Float16Array in loose deep equality checks
953aa21
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@LiviaMedeiros@RafaelGSS
assert: support Float16Array in loose deep equality checks
7df9558
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
70a75d2
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
d3ed6f8
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@LiviaMedeiros@RafaelGSS
assert: support Float16Array in loose deep equality checks
3b774ef
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
2c1e289
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
ec85d05
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
a2af829
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@LiviaMedeiros@aduh95
assert: support Float16Array in loose deep equality checks
4252dc7
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LiviaMedeiros@nodejs-github-bot@jasnell@lpinca@BridgeAR@aduh95