Skip to content

test: Enable skipped colorize test - #57887

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:fix/colorizetest
Apr 18, 2025
Merged

test: Enable skipped colorize test#57887
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:fix/colorizetest

Conversation

@islandryu

@islandryuislandryu commented Apr 15, 2025

Copy link
Copy Markdown
Member
constcanColorize=process.stderr?.isTTY&&(typeofprocess.stderr?.getColorDepth==='function' ?
process.stderr?.getColorDepth()>2 : true);

When executed with "make test", canColorize in "test-runner-output.mjs" always seems to be false.
This causes a discrepancy when running the test directly.

@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 15, 2025
@codecov

codecovBot commented Apr 15, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (86f86a2) to head (4269836).
Report is 43 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57887 +/- ##
==========================================
+ Coverage 90.22% 90.26% +0.03% 
==========================================
Files 630 630 Lines 185481 185688 +207 Branches 36364 36410 +46 ==========================================
+ Hits 167357 167614 +257 + Misses 11004 10963 -41 + Partials 7120 7111 -9

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66309/

@nodejs-github-bot

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66314/

@nodejs-github-bot

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66321/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 6cdcaa9 into nodejs:mainApr 18, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator

Landed in 6cdcaa9

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@islandryu@RafaelGSS
test: enable skipped colorize test
065b4a3
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@islandryu@RafaelGSS
test: enable skipped colorize test
7039173
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu@aduh95
test: enable skipped colorize test
66d1121
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu@aduh95
test: enable skipped colorize test
833b153
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@islandryu@RafaelGSS
test: enable skipped colorize test
c3d20f0
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@islandryu@aduh95
test: enable skipped colorize test
b03db3f
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@islandryu@aduh95
test: enable skipped colorize test
a6db25e
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@islandryu@aduh95
test: enable skipped colorize test
910aa8c
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@islandryu@aduh95
test: enable skipped colorize test
aa755d3
PR-URL: #57887
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@islandryu@nodejs-github-bot@lpinca@atlowChemi