Skip to content

build: remove redundant -mXX flags for V8 - #57907

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:m32-64
Apr 19, 2025
Merged

build: remove redundant -mXX flags for V8#57907
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:m32-64

Conversation

@targos

@targostargos commented Apr 17, 2025

Copy link
Copy Markdown
Member

They are already set by common.gypi.

@targos
build: remove redundant -mXX flags for V8
a633c09
They are already set by `common.gypi`.
@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 17, 2025
@nodejs-github-bot

This comment was marked as resolved.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66347/ 💚

@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 18, 2025
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57907
✔ Done loading data for nodejs/node/pull/57907
----------------------------------- PR info ------------------------------------
Title build: remove redundant `-mXX` flags for V8 (#57907)
Author Michaël Zasso <targos@protonmail.com> (@targos)
Branch targos:m32-64 -> nodejs:main
Labels v8 engine, tools, author ready, needs-ci
Commits 2
- build: remove redundant `-mXX` flags for V8
- fixup: remove now unused variables
Committers 1
- Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/57907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Thu, 17 Apr 2025 09:39:13 GMT
✔ Approvals: 5
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2775831274
✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778577919
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778623340
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778639380
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57907#pullrequestreview-2779209617
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-04-18T12:46:51Z: https://ci.nodejs.org/job/node-test-pull-request/66347/
- Querying data for job/node-test-pull-request/66347/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 57907
From https://github.com/nodejs/node
* branch refs/pull/57907/merge -> FETCH_HEAD
✔ Fetched commits as 63640eb32d58..3b7d17ee2892
--------------------------------------------------------------------------------
[main b275a7eb38] build: remove redundant `-mXX` flags for V8
Author: Michaël Zasso <targos@protonmail.com>
Date: Thu Apr 17 11:38:23 2025 +0200
1 file changed, 64 deletions(-)
[main d098d40c0b] fixup: remove now unused variables
Author: Michaël Zasso <targos@protonmail.com>
Date: Thu Apr 17 11:40:05 2025 +0200
1 file changed, 27 deletions(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
build: remove redundant `-mXX` flags for V8

They are already set by common.gypi.
PR-URL: #57907

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
[detached HEAD dc5b119733] build: remove redundant -mXX flags for V8

Author: Michaël Zasso <targos@protonmail.com>

Date: Thu Apr 17 11:38:23 2025 +0200

1 file changed, 64 deletions(-)

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup: remove now unused variables
PR-URL: #57907

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
[detached HEAD 9fad5da2ff] fixup: remove now unused variables

Author: Michaël Zasso <targos@protonmail.com>

Date: Thu Apr 17 11:40:05 2025 +0200

1 file changed, 27 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/14547939233

@targostargos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 19, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 2b76dca into nodejs:mainApr 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

Landed in 2b76dca

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@targos@RafaelGSS
build: remove redundant -mXX flags for V8
7755d19
They are already set by `common.gypi`.
PR-URL: #57907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@targos@RafaelGSS
build: remove redundant -mXX flags for V8
403264c
They are already set by `common.gypi`.
PR-URL: #57907
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95aduh95 added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label May 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@legendecaslegendecaslegendecas approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos@nodejs-github-bot@jasnell@lpinca@legendecas@RafaelGSS@marco-ippolito@aduh95