util: add internal `assignFunctionName()` function by LiviaMedeiros · Pull Request #57916 · nodejs/node

LiviaMedeiros · 2025-04-17T17:29:30Z

Extracted from: #57901

We have a lot of functions exposed to userspace or mentioned in stack traces that are anonymous or have something inherited like value as name; because it's not convenient to define it with name, or because the correct name is already taken by another variable, or because the name comes from a Symbol, or because of false positives from linter.

This helper function will simplify giving such functions a correct name.

BridgeAR · 2025-04-17T17:37:15Z

I think it's best to introduce the helper in the other PR, since it is used that way.

LiviaMedeiros · 2025-04-17T17:52:59Z

I extracted this so it could be used for other namings (e.g. for some [Symbol(nodejs.util.promisify.custom)] functions), since it's not related to the other PR, doesn't have to depend on it, and would simplify the process (especially for backports and cherry-picking later). But it's feasible either way.

BridgeAR · 2025-04-17T18:00:07Z

I would definitely like adding usages right away. It would otherwise feel weird to me to add a utility function for internal usage only. We could of course split it into two commits in the same PR.

codecov · 2025-04-17T18:21:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (609df89) to head (5292de9).
Report is 127 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #57916 +/- ##
==========================================
- Coverage 90.27% 90.27% -0.01% 
==========================================
Files 630 630 Lines 186112 186145 +33 Branches 36464 36471 +7 ==========================================
+ Hits 168013 168042 +29 + Misses 10981 10970 -11 - Partials 7118 7133 +15

Files with missing lines	Coverage Δ
lib/child_process.js	`97.75% <100.00%> (+<0.01%)`	⬆️
lib/internal/http2/core.js	`95.63% <100.00%> (+<0.01%)`	⬆️
lib/internal/util.js	`96.30% <100.00%> (+0.56%)`	⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

H4ad

Should this be marked as minor since we change the behavior a little bit (although it's not disrupting)?

aduh95 · 2025-04-19T13:35:33Z

If we change the semverness of this PR, we should definitely split it in several PRs to simplify work for releasers

LiviaMedeiros · 2025-04-19T13:50:46Z

Should this be marked as minor since we change the behavior a little bit (although it's not disrupting)?

I'm okay with semverness change if needed, but not sure it can be semver-minor, since it doesn't add any userland-facing features. IMHO the helper function by itself is semver-patch, and the other changes are either semver-patch fixes or semver-major (potentially) breaking fixes.

nodejs-github-bot · 2025-04-19T22:42:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66372/

nodejs-github-bot · 2025-05-04T08:25:14Z

Landed in 9acf6af...a44ccac

PR-URL: #57916 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#57916

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57916

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>

nodejs/node#57916

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>

* chore: bump node in DEPS to v22.17.0 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * chore: adjust crypto specs: - nodejs/node#58117 - nodejs/node#58387 * deps: update libuv to 1.51.0 nodejs/node#58124 * test: fix test-buffer-tostring-range on allocation failure nodejs/node#58416 * build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch nodejs/node#58090 * build: use //third_party/simdutf by default in GN nodejs/node#58115 * inspector: add protocol method Network.dataReceived nodejs/node#58001 * test: force slow JSON.stringify path for overflow nodejs/node#58181 * chore: fixup patch indices * 6049967: Remove protocol::Maybe and roll inspector_protocol https://chromium-review.googlesource.com/c/chromium/src/+/6049967 * chore: fixup crypto test patch * src: fix module buffer allocation nodejs/node#57738 * crypto: expose process.features.openssl_is_boringssl nodejs/node#58387 * util: add internal assignFunctionName() function nodejs/node#57916 * build: fix pointer compression builds nodejs/node#58171 * chore: put back config options * fixup! deps: update libuv to 1.51.0 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 17, 2025

LiviaMedeiros mentioned this pull request Apr 17, 2025
http2: give name to promisified connect()#57913
Closed

LiviaMedeiros added lib / src Issues and PRs related to general changes in the lib or src directory. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 18, 2025

LiviaMedeiros force-pushed the util-internal-assign-function-name branch from fd20019 to 18b89d3Compare April 18, 2025 06:39

aduh95 reviewed Apr 19, 2025
View reviewed changes

Comment threadlib/internal/util.js Outdated

aduh95 reviewed Apr 19, 2025
View reviewed changes

Comment threadlib/child_process.js Outdated

aduh95 reviewed Apr 19, 2025
View reviewed changes

Comment threadlib/internal/util.js Outdated

LiviaMedeiros self-assigned this Apr 19, 2025

aduh95 approved these changes Apr 19, 2025
View reviewed changes

Comment threadlib/internal/util.js Outdated

H4ad approved these changes Apr 19, 2025
View reviewed changes

jasnell reviewed Apr 19, 2025
View reviewed changes

Comment threadlib/internal/http2/core.js Outdated

LiviaMedeiros added 2 commits April 20, 2025 01:34

util: add internal assignFunctionName() function
d139b6d

child_process: give names to promisified exec() and execFile()
f43b61e

LiviaMedeiros force-pushed the util-internal-assign-function-name branch from 83ced41 to 22c521bCompare April 19, 2025 17:35

aduh95 approved these changes Apr 19, 2025
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 19, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025

LiviaMedeiros removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2025

LiviaMedeiros force-pushed the util-internal-assign-function-name branch from ee4de6c to 32d29feCompare April 20, 2025 06:58

This comment was marked as outdated.
Sign in to view

LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2025

nodejs-github-bot closed this May 4, 2025

github-actionsBot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged

github-actionsBot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged

codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025
util: add internal assignFunctionName() function
e269c8d
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
util: add internal assignFunctionName() function
a5f0c14
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
util: add internal assignFunctionName() function
74bf949
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
208f539
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
4158ec5
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
1e1b161
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
a80967f
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
6a87e3a
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
util: add internal assignFunctionName() function
0b9023c
nodejs/node#57916

codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
util: add internal assignFunctionName() function
c19bb8e
nodejs/node#57916

Navigation Menu

Uh oh!

Uh oh!

util: add internal `assignFunctionName()` function - #57916

util: add internal `assignFunctionName()` function#57916
LiviaMedeiros wants to merge 3 commits into
nodejs:mainfrom
LiviaMedeiros:util-internal-assign-function-name

LiviaMedeiros commented Apr 17, 2025

Uh oh!

BridgeAR commented Apr 17, 2025

Uh oh!

LiviaMedeiros commented Apr 17, 2025

Uh oh!

BridgeAR commented Apr 17, 2025

Uh oh!

codecovBot commented Apr 17, 2025•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

H4ad left a comment

Uh oh!

aduh95 commented Apr 19, 2025

Uh oh!

LiviaMedeiros commented Apr 19, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

LiviaMedeiros commented Apr 17, 2025

Uh oh!

BridgeAR commented Apr 17, 2025

Uh oh!

LiviaMedeiros commented Apr 17, 2025

Uh oh!

BridgeAR commented Apr 17, 2025

Uh oh!

codecovBot commented Apr 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

H4ad left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Apr 19, 2025

Uh oh!

LiviaMedeiros commented Apr 19, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecovBot commented Apr 17, 2025•
edited
Loading