Skip to content

build: use clang-cl in coverage-windows workflow - #57919

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:win-clang-action
Apr 19, 2025
Merged

build: use clang-cl in coverage-windows workflow#57919
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:win-clang-action

Conversation

@targos

Copy link
Copy Markdown
Member

And do not lose time trying to regenerate the project and rebuild
before running the tests.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 17, 2025
@targos

Copy link
Copy Markdown
MemberAuthor

/cc @StefanStojanovic

@targostargos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 17, 2025
And do not lose time trying to regenerate the project and rebuild
before running the tests.
@targostargos changed the title build: use clang-cl in coverage-action workflowbuild: use clang-cl in coverage-windows workflowApr 17, 2025
@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 18, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 25842c5 into nodejs:mainApr 19, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 25842c5

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
And do not lose time trying to regenerate the project and rebuild
before running the tests.
PR-URL: #57919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
And do not lose time trying to regenerate the project and rebuild
before running the tests.
PR-URL: #57919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@lpinca@anonrig