Skip to content

watch: clarify completion/failure watch mode messages - #57926

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/node-watch-waiting-msg
Apr 24, 2025
Merged

watch: clarify completion/failure watch mode messages#57926
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/node-watch-waiting-msg

Conversation

@dario-piotrowicz

@dario-piotrowiczdario-piotrowicz commented Apr 18, 2025•
edited
Loading

Copy link
Copy Markdown
Member

clarify the messages that node --watch presents to the user when the process terminates (either successfully or because of some error) by clearly conveying that node is waiting for new file changes before restarting the process

I am not sure if it fixes it but it might partially help with #57657

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 18, 2025
@codecov

codecovBot commented Apr 18, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (25842c5) to head (026d28c).
Report is 27 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57926 +/- ##
==========================================
- Coverage 92.26% 90.26% -2.00% 
==========================================
Files 325 630 +305 Lines 126673 186112 +59439 Branches 20783 36462 +15679 ==========================================
+ Hits 116869 167999 +51130 - Misses 9576 10989 +1413 - Partials 228 7124 +6896

see 412 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowiczdario-piotrowicz changed the title cli: clarify completion/failure watch mode messageswatch: clarify completion/failure watch mode messagesApr 19, 2025
@dario-piotrowicz
dario-piotrowiczforce-pushed the dario/node-watch-waiting-msg branch from d4e6917 to 2534427CompareApril 19, 2025 22:01
@dario-piotrowicz
watch: clarify completion/failure watch mode messages
026d28c
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
@dario-piotrowicz
dario-piotrowiczforce-pushed the dario/node-watch-waiting-msg branch from 2534427 to 026d28cCompareApril 19, 2025 22:50
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66396/

@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66419/

@jakecastellijakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. watch-mode Issues and PRs related to watch mode labels Apr 24, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b665127 into nodejs:mainApr 24, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in b665127

@dario-piotrowicz
dario-piotrowicz deleted the dario/node-watch-waiting-msg branch April 24, 2025 19:18
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@dario-piotrowicz@RafaelGSS
watch: clarify completion/failure watch mode messages
24cf976
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@dario-piotrowicz@RafaelGSS
watch: clarify completion/failure watch mode messages
cb7eb15
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@dario-piotrowiczdario-piotrowicz mentioned this pull request May 5, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 6, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
8d73c83
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
b5ef287
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@dario-piotrowicz@RafaelGSS
watch: clarify completion/failure watch mode messages
861b338
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
6ec9dd5
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
bd170b4
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
8f02f49
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@dario-piotrowicz@aduh95
watch: clarify completion/failure watch mode messages
af41dd3
clarify the messages that `node --watch` presents to the user
when the process terminates (either successfully or because of
some error) by clearly conveying that node is waiting for new
file changes before restarting the process
PR-URL: #57926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dario-piotrowicz@nodejs-github-bot@jasnell@lpinca@marco-ippolito@jakecastelli