Skip to content

test: force GC in test-file-write-stream4 - #57930

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:deflake/test-file-write-stream4
Apr 20, 2025
Merged

test: force GC in test-file-write-stream4#57930
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:deflake/test-file-write-stream4

Conversation

@lpinca

@lpincalpinca commented Apr 18, 2025

Copy link
Copy Markdown
Member

Reduce test/parallel/test-file-write-stream4.js flakiness.

Refs: #57927

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 18, 2025
@lpinca

Copy link
Copy Markdown
MemberAuthor

Alternative to #57927.

@lpinca

lpinca commented Apr 18, 2025

Copy link
Copy Markdown
MemberAuthor

I think we can land this before #57927, and see if it has the desired effect. If it doesn't, we can revert and land #57927 instead.

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this and the PR marking this test as flaky are mutually exclusive. We can do both then remove the flaky flag once we believe it has been fixed.

@lpinca
lpincaforce-pushed the deflake/test-file-write-stream4 branch 2 times, most recently from 4c82143 to 563da32CompareApril 18, 2025 18:26
@lpinca

lpinca commented Apr 18, 2025

Copy link
Copy Markdown
MemberAuthor

In my opinion, landing both does not make much sense.

@lpinca

Copy link
Copy Markdown
MemberAuthor
$ npx envinfo --system
System:
OS: macOS 15.4.1
CPU: (16) x64 Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz
Memory: 1.66 GB / 32.00 GB
Shell: 5.2.37 - /usr/local/bin/bash

Before the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
=== release test-file-write-stream4 === Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---
=== release test-file-write-stream4 === Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---
...
[04:15|% 100|+ 982|- 18]: Done
Failed tests:
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
...

After the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
[01:13|% 100|+ 1000|- 0]: Done All tests passed.

@codecov

codecovBot commented Apr 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (52d95f5) to head (5bfd30f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57930 +/- ##
==========================================
+ Coverage 90.26% 90.27% +0.01% 
==========================================
Files 630 630 Lines 185933 185933 Branches 36450 36443 -7 ==========================================
+ Hits 167829 167853 +24 + Misses 10972 10964 -8 + Partials 7132 7116 -16 

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: nodejs#57927
@lpinca
lpincaforce-pushed the deflake/test-file-write-stream4 branch from 563da32 to 5bfd30fCompareApril 19, 2025 07:59
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
@lpincalpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 422529a into nodejs:mainApr 20, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 422529a

@lpinca
lpinca deleted the deflake/test-file-write-stream4 branch April 20, 2025 18:37
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 5, 2025
@ghostghost mentioned this pull request Jun 8, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.
Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@lpinca@nodejs-github-bot@jasnell@anonrig@LiviaMedeiros@aduh95