src: add DCHECK_EQ for Object::New calls

[JonasBa]

Add DCHECK_EQ check before other Object::New calls as in #57942

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (25842c5) to head (a5e1ac0).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #57943 +/- ##
==========================================
- Coverage 92.26% 90.27% -1.99% 
==========================================
Files 325 630 +305 Lines 126673 186124 +59451 Branches 20783 36476 +15693 ==========================================
+ Hits 116869 168025 +51156 - Misses 9576 10969 +1393 - Partials 228 7130 +6902 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	80.53% <83.33%> (ø)

... and 411 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66380/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66390/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/57943
✔ Done loading data for nodejs/node/pull/57943
----------------------------------- PR info ------------------------------------
Title src: add DCHECK_EQ for Object::New calls (#57943)
Author Jonas <jonas@badalic.com> (@JonasBa)
Branch JonasBa:jb/sqlite/dcheck -> nodejs:main
Labels c++, author ready, needs-ci, sqlite
Commits 2
- src: add dcheck_eq for Object::New constructor calls
- Update src/node_sqlite.cc
Committers 2
- JonasBa <jonas@badalic.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/57943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 20 Apr 2025 01:29:45 GMT
✔ Approvals: 3
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57943#pullrequestreview-2780379522
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57943#pullrequestreview-2780124634
✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57943#pullrequestreview-2780125216
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-04-21T01:10:41Z: https://ci.nodejs.org/job/node-test-pull-request/66390/
- Querying data for job/node-test-pull-request/66390/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 57943
From https://github.com/nodejs/node
* branch refs/pull/57943/merge -> FETCH_HEAD
✔ Fetched commits as 1720b18260d7..a5e1ac077a60
--------------------------------------------------------------------------------
Auto-merging src/node_sqlite.cc
[main f4e6744210] src: add dcheck_eq for Object::New constructor calls
Author: JonasBa <jonas@badalic.com>
Date: Sat Apr 19 21:27:44 2025 -0400
1 file changed, 8 insertions(+)
Auto-merging src/node_sqlite.cc
[main 45d72070e8] Update src/node_sqlite.cc
Author: Jonas <jonas@badalic.com>
Date: Sun Apr 20 20:45:29 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: add dcheck_eq for Object::New constructor calls
PR-URL: #57943

Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
[detached HEAD 00ede690ea] src: add dcheck_eq for Object::New constructor calls

Author: JonasBa <jonas@badalic.com>

Date: Sat Apr 19 21:27:44 2025 -0400

1 file changed, 8 insertions(+)

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update src/node_sqlite.cc
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #57943

Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
[detached HEAD e884bc5a14] Update src/node_sqlite.cc

Author: Jonas <jonas@badalic.com>

Date: Sun Apr 20 20:45:29 2025 -0400

1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/14602649024

[nodejs-github-bot]

Landed in 68cc1c9