Skip to content

src: avoid calling SetPrototypeV2() - #57949

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/avoid-set-prototypev2
Apr 22, 2025
Merged

src: avoid calling SetPrototypeV2()#57949
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/avoid-set-prototypev2

Conversation

@anonrig

@anonriganonrig commented Apr 20, 2025

Copy link
Copy Markdown
Member

Setting the prototype can be achieved by the v8::Object::New() constructor. We don't need to call SetPrototypeV2().

@anonrig
anonrig requested a review from jasnellApril 20, 2025 15:17
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 20, 2025
@anonrig
anonrigforce-pushed the yagiz/avoid-set-prototypev2 branch from 9578bd1 to 24013beCompareApril 20, 2025 15:18
@anonrig
anonrigforce-pushed the yagiz/avoid-set-prototypev2 branch from 24013be to ff7cf87CompareApril 20, 2025 15:24
@anonrig
anonrig requested review from aduh95 and mcollinaApril 20, 2025 15:26
@codecov

codecovBot commented Apr 20, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (afd318d) to head (ff7cf87).
Report is 156 commits behind head on main.

Files with missing linesPatch %Lines
src/api/environment.cc50.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #57949 +/- ##
==========================================
+ Coverage 90.26% 90.27% +0.01% 
==========================================
Files 630 630 Lines 186083 186105 +22 Branches 36454 36461 +7 ==========================================
+ Hits 167962 168003 +41 + Misses 10985 10970 -15 + Partials 7136 7132 -4
Files with missing linesCoverage Δ
src/node_constants.cc99.71% <100.00%> (+2.53%)⬆️
src/api/environment.cc75.13% <50.00%> (+0.13%)⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell
jasnell reviewed Apr 20, 2025
View reviewed changes
Comment threadsrc/node_constants.cc
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 20, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66385/

@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66386/

aduh95
aduh95 approved these changes Apr 20, 2025
View reviewed changes
Comment threadsrc/node_constants.cc
@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66387/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2025
mcollina
mcollina approved these changes Apr 21, 2025
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 1c0a405 into nodejs:mainApr 22, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Landed in 1c0a405

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@anonrig@RafaelGSS
src: avoid calling SetPrototypeV2()
100d7e0
PR-URL: #57949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@anonrig@RafaelGSS
src: avoid calling SetPrototypeV2()
b405515
PR-URL: #57949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025
@aduh95

aduh95 commented May 6, 2025

Copy link
Copy Markdown
Contributor

This doesn't land cleanly on v22.x-staging

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-requested-v22.xPRs awaiting manual backport to the v22.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@aduh95@mcollina@jasnell@lpinca