Skip to content

crypto: fix cross-realm SharedArrayBuffer validation - #57974

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:cross-realm-sab
Apr 24, 2025
Merged

crypto: fix cross-realm SharedArrayBuffer validation#57974
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:cross-realm-sab

Conversation

@aduh95

@aduh95aduh95 commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

#57828 only fixed the code for ArrayBuffer, let's handle SharedArrayBuffer as well. This also refactors the test to include the nits that didn't make it in the original PR.

@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 22, 2025
@codecov

codecovBot commented Apr 22, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (6bf7fd7) to head (2454b4b).
Report is 13 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57974 +/- ##
=======================================
Coverage 90.27% 90.28% =======================================
Files 630 630 Lines 186168 186158 -10 Branches 36482 36479 -3 =======================================
- Hits 168066 168065 -1 + Misses 10975 10966 -9 
Partials 7127 7127
Files with missing linesCoverage Δ
lib/internal/crypto/webidl.js98.60% <100.00%> (+0.11%)⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 22, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66414/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 5d15cbb into nodejs:mainApr 24, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in 5d15cbb

@aduh95
aduh95 deleted the cross-realm-sab branch April 24, 2025 14:05
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95@RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
b34212b
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95@RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
234c710
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
c6e8307
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
2ed01b2
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95@RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
8be5418
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
f02f562
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
61e5717
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 18, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
5afb3e7
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
53c5fdc
PR-URL: #57974
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@jasnelljasnelljasnell approved these changes
@legendecaslegendecaslegendecas approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@ljharb@jasnell@legendecas@marco-ippolito