Skip to content

src: use ranges library (C++20) to simplify code - #57975

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
lemire:using_ranges
Apr 25, 2025
Merged

src: use ranges library (C++20) to simplify code#57975
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
lemire:using_ranges

Conversation

@lemire

@lemirelemire commented Apr 22, 2025

Copy link
Copy Markdown
Member

This PR uses C++20 ranges to slightly simplify a piece of code. To be honest, the real motivation of this PR is to introduce ranges and test whether the platforms play nice with ranges. If so, then this could be generalized in the code base.

@lemire
lemire requested a review from codebytereApril 22, 2025 15:36
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Apr 22, 2025
@lemire
lemire requested a review from anonrigApril 22, 2025 15:38
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2025
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 22, 2025
@github-actions

github-actionsBot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ Commits were pushed since the last approving review:
⚠ - src: use ranges library (C++20) to simplify code
⚠ - breaking long lines
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14598958420

@richardlau

richardlau commented Apr 22, 2025

Copy link
Copy Markdown
Member

Looks like a missing #include <algorithm>:
https://github.com/nodejs/node/actions/runs/14598914061/job/40951831889?pr=57975#step:6:6555

In file included from ../src/node_options.cc:2:
../src/node_options-inl.h:398:20: error: no member named 'for_each' in namespace 'std::ranges'
398 | std::ranges::for_each(
| ~~~~~~~~~~~~~^

@aduh95aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 22, 2025
@lemire

lemire commented Apr 22, 2025

Copy link
Copy Markdown
MemberAuthor

@richardlau good catch.

@anonrig

anonrig commented Apr 22, 2025

Copy link
Copy Markdown
Member

@lemire It seems it doesn't build on any platforms at all

@lemire

lemire commented Apr 23, 2025

Copy link
Copy Markdown
MemberAuthor

@anonrig

It seems it doesn't build on any platforms at all

It should build. Let us find out what the issue is.

@codecov

codecovBot commented Apr 24, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (367d593) to head (8289bba).
Report is 17 commits behind head on main.

Files with missing linesPatch %Lines
src/node_options-inl.h88.88%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #57975 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.02% 
==========================================
Files 630 630 Lines 186169 186169 Branches 36479 36479 ==========================================
- Hits 168082 168062 -20 - Misses 10971 10974 +3 - Partials 7116 7133 +17
Files with missing linesCoverage Δ
src/node_options-inl.h81.30% <88.88%> (+0.48%)⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lemire

lemire commented Apr 24, 2025

Copy link
Copy Markdown
MemberAuthor

@anonrig I am unhappy with the formatting of the code, but it works now !!!!!!!!!

@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 24, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66433/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 25, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 25fe802 into nodejs:mainApr 25, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

Landed in 25fe802

@lemirelemire mentioned this pull request Apr 25, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@lemire@RafaelGSS
src: use ranges library (C++20) to simplify code
95e8249
PR-URL: #57975
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@lemire@RafaelGSS
src: use ranges library (C++20) to simplify code
88f047b
PR-URL: #57975
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
@codebyterecodebyterecodebytere approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.configIssues or PRs related to the config subsystemdont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lemire@richardlau@anonrig@nodejs-github-bot@jasnell@codebytere@aduh95