test_runner: support mocking json modules by JakobJingleheimer · Pull Request #58007 · nodejs/node

JakobJingleheimer · 2025-04-24T14:49:08Z

No description provided.

nodejs-github-bot · 2025-04-24T14:49:13Z

Review requested:

@nodejs/test_runner

JakobJingleheimer · 2025-04-24T14:51:39Z

+This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON modules, and
+Node.js builtin modules. Any references to the original module prior to mocking are not impacted. In
+order to enable module mocking, Node.js must be started with the
+[`--experimental-test-module-mocks`][] command-line flag.


The only change here was to add JSON modules,.

Let's minimize the diff
Suggested change
This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON modules, and
Node.js builtin modules. Any references to the original module prior to mocking are not impacted. In
order to enable module mocking, Node.js must be started with the
[`--experimental-test-module-mocks`][] command-line flag.
This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON
modules, and Node.js builtin modules. Any references to the original module
prior to mocking are not impacted. In order to enable module mocking, Node.js must
be started with the [`--experimental-test-module-mocks`][] command-line flag.

JakobJingleheimer · 2025-04-24T14:52:22Z

+ case 'json':
+ format = 'module';


This is the main change. Creating a nested ternary seemed messy, so I changed this to a switch.

JakobJingleheimer · 2025-04-24T14:52:39Z

+ 'builtin',
+ 'commonjs-typescript',
+ 'commonjs',
+ 'json',


Adding 'json', was the only real change here.

pmarchini · 2025-04-24T15:03:04Z

Except for the linting issue: LGTM

JakobJingleheimer · 2025-04-24T15:05:29Z

Got to it a split-second after you. Could you re-approve since now there has to be at least approval on the most recent commit.

codecov · 2025-04-24T15:53:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (5d15cbb) to head (4e1ed7a).
Report is 10 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58007 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01% 
==========================================
Files 630 630 Lines 186158 186172 +14 Branches 36472 36474 +2 ==========================================
+ Hits 168047 168092 +45 + Misses 10976 10964 -12 + Partials 7135 7116 -19

Files with missing lines	Coverage Δ
lib/internal/test_runner/mock/loader.js	`95.67% <100.00%> (+0.15%)`	⬆️
lib/internal/test_runner/mock/mock.js	`99.26% <100.00%> (+<0.01%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-04-24T16:09:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66439/

nodejs-github-bot · 2025-04-25T11:13:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66451/

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 · 2025-04-25T13:31:41Z

+ - version:
+ - REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/58007
+ description: Support JSON modules.


nit
Suggested change
description: Support JSON modules.
description: Add support for JSON modules mocking.

aduh95 · 2025-04-25T13:32:39Z

+This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON modules, and
+Node.js builtin modules. Any references to the original module prior to mocking are not impacted. In
+order to enable module mocking, Node.js must be started with the
+[`--experimental-test-module-mocks`][] command-line flag.


Let's minimize the diff
Suggested change
This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON modules, and
Node.js builtin modules. Any references to the original module prior to mocking are not impacted. In
order to enable module mocking, Node.js must be started with the
[`--experimental-test-module-mocks`][] command-line flag.
This function is used to mock the exports of ECMAScript modules, CommonJS modules, JSON
modules, and Node.js builtin modules. Any references to the original module
prior to mocking are not impacted. In order to enable module mocking, Node.js must
be started with the [`--experimental-test-module-mocks`][] command-line flag.

aduh95 · 2025-04-25T13:36:26Z

nit: we could use an existing fixtures JSON file (e.g. test/fixtures/experimental.json), or at least move/rename it to test/fixtures/simple.json so it can be used by other tests

nodejs-github-bot · 2025-04-25T16:10:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66456/

nodejs-github-bot · 2025-04-26T08:28:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66464/

nodejs-github-bot · 2025-04-26T09:46:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66466/

nodejs-github-bot · 2025-04-26T14:56:25Z

Landed in cf896c3

PR-URL: #58007 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

JakobJingleheimer added the test_runner Issues and PRs related to the test runner subsystem. label Apr 24, 2025

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 24, 2025

test_runner: support mocking json modules
8961496

JakobJingleheimer force-pushed the test_runner/feat/json-module-mock branch from acca0d8 to 8961496Compare April 24, 2025 14:50

cjihrig approved these changes Apr 24, 2025
View reviewed changes

JakobJingleheimer commented Apr 24, 2025
View reviewed changes

Comment threaddoc/api/test.md Outdated

pmarchini approved these changes Apr 24, 2025
View reviewed changes

fixup!: de-lint
17764f7

pmarchini approved these changes Apr 24, 2025
View reviewed changes

JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2025

marco-ippolito approved these changes Apr 25, 2025
View reviewed changes

aduh95 reviewed Apr 25, 2025
View reviewed changes

Comment threadtest/parallel/test-runner-module-mocking.js

fixup!: add test case to ensure import attributes are still required
32a4f02

atlowChemi approved these changes Apr 25, 2025
View reviewed changes

aduh95 reviewed Apr 25, 2025
View reviewed changes

Comment threadtest/parallel/test-runner-module-mocking.js Outdated

fixup!: don't pre-load original before testing rejection
4e1ed7a
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 approved these changes Apr 25, 2025
View reviewed changes

JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025

pmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2025

JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 26, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2025

nodejs-github-bot merged commit cf896c3 into nodejs:mainApr 26, 2025

JakobJingleheimer deleted the test_runner/feat/json-module-mock branch April 29, 2025 08:19

RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged

github-actionsBot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged

	description: Support JSON modules.
	description: Add support for JSON modules mocking.

Uh oh!

Uh oh!

Conversation

JakobJingleheimer commented Apr 24, 2025

Uh oh!

nodejs-github-bot commented Apr 24, 2025• edited by JakobJingleheimer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JakobJingleheimerApr 24, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimerApr 24, 2025

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimerApr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pmarchini commented Apr 24, 2025

Uh oh!

JakobJingleheimer commented Apr 24, 2025

Uh oh!

codecovBot commented Apr 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 24, 2025

Uh oh!

nodejs-github-bot commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

aduh95Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

aduh95Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 25, 2025

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

nodejs-github-bot commented Apr 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Apr 24, 2025•
edited by JakobJingleheimer
Loading

codecovBot commented Apr 24, 2025•
edited
Loading