Skip to content

test: add fast api tests for getLibuvNow() - #58022

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/add-libuv-fast-api
Apr 27, 2025
Merged

test: add fast api tests for getLibuvNow()#58022
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/add-libuv-fast-api

Conversation

@anonrig

@anonriganonrig commented Apr 25, 2025

Copy link
Copy Markdown
Member

Adds a test for the v8 fast api we use for getLibuvNow() method.

@anonrig
anonrig requested review from jasnell and targosApril 25, 2025 14:25
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Apr 25, 2025
@anonrig
anonrigforce-pushed the yagiz/add-libuv-fast-api branch from 1171c3a to ee7237fCompareApril 25, 2025 14:25
@anonriganonrig changed the title Yagiz/add libuv fast apitest: add fast api tests for getLibuvNow()Apr 25, 2025
@codecov

codecovBot commented Apr 25, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (9cc0195) to head (5b01f13).
Report is 11 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58022 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01% 
==========================================
Files 630 630 Lines 186158 186328 +170 Branches 36484 36503 +19 ==========================================
+ Hits 168067 168205 +138 - Misses 10974 11004 +30 - Partials 7117 7119 +2
Files with missing linesCoverage Δ
src/timers.cc88.69% <100.00%> (+2.60%)⬆️
src/timers.h100.00% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 25, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66459/

@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66461/

@anonrig
anonrigforce-pushed the yagiz/add-libuv-fast-api branch from ee7237f to 5b01f13CompareApril 26, 2025 21:02
@anonrig
anonrig requested a review from H4adApril 26, 2025 22:48
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66477/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 145c6a2 into nodejs:mainApr 27, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

Landed in 145c6a2

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@anonrig@RafaelGSS
test: add fast api tests for getLibuvNow()
0c027cd
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@anonrig@RafaelGSS
test: add fast api tests for getLibuvNow()
3d34c5f
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
ebce0f8
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
31e202c
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@anonrig@RafaelGSS
test: add fast api tests for getLibuvNow()
ec66174
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
558cf75
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
4ae425d
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
a31f538
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@anonrig@aduh95
test: add fast api tests for getLibuvNow()
b407692
PR-URL: #58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@H4adH4adH4ad approved these changes
@aduh95aduh95aduh95 approved these changes
@targostargosAwaiting requested review from targos

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@jasnell@H4ad@aduh95