Uh oh!
There was an error while loading. Please reload this page.
dns: use isIp consistently - #5804
Closed
benjamingr wants to merge 1 commit into
Closed
Conversation
Currently the DNS module imports isIP from both cares and `net` and uses both of them both throughout the code base. This PR removes the direct dependency `dns` has on `net` and uses `isIp` from c-ares all the time. Note that both functions do the same thing. PR-URL: Reviewed-By: Reviewed-By:
benjamingrforce-pushed
the
dns-use-isip-consistently
branch
from
March 19, 2016 19:56
1eb87bf to
65acb8dCompareTrott
commented
Mar 19, 2016
Member
LGTM if CI is green |
benjamingr
commented
Mar 19, 2016
MemberAuthor
cjihrig
commented
Mar 20, 2016
Contributor
You might get some push back because a lot of this is style only. That said, dropping |
thefourtheye
commented
Mar 20, 2016
Contributor
LGTM. |
benjamingr
commented
Mar 20, 2016
MemberAuthor
@cjihrig well, this specific change isn't style only (it's just dropping the dependency). As for the others, I don't consider the push-back negative, as long as people are discussing it and we can reach consensus and improve the code base I'm all for it (and I know this requires some extra work and writing a lot of code that'll never make it in and I'm fine with that too). Thanks for the concern :) |
evanlucas
commented
Mar 20, 2016
Contributor
LGTM if CI is happy |
jasnell
commented
Mar 21, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Mar 21, 2016
Currently the DNS module imports isIP from both cares and `net` and uses both of them both throughout the code base. This PR removes the direct dependency `dns` has on `net` and uses `isIp` from c-ares all the time. Note that both functions do the same thing. PR-URL: #5804 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 21, 2016
Member
Landed in b929988 |
benjamingr
commented
Mar 21, 2016
MemberAuthor
Thanks :) |
Fishrock123 pushed a commit
that referenced
this pull request
Mar 22, 2016
Currently the DNS module imports isIP from both cares and `net` and uses both of them both throughout the code base. This PR removes the direct dependency `dns` has on `net` and uses `isIp` from c-ares all the time. Note that both functions do the same thing. PR-URL: #5804 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: lib/dns.js
MylesBorins
commented
Mar 30, 2016
Contributor
this change is not landing cleanly on v4 due to @benjamingr would you be able to manually backport to v4 and send a PR? |
benjamingr
commented
Mar 31, 2016
MemberAuthor
Sure |
MylesBorins
commented
Apr 8, 2016
Contributor
@benjamingr ping 😄 |
MylesBorins
commented
May 17, 2016
Contributor
@benjamingr ping |
MylesBorins
commented
Jun 1, 2016
Contributor
@benjamingr hey buddy... hows it going? |
benjamingr
commented
Jun 2, 2016
MemberAuthor
I totally forgot about this again - so not good :D |
MylesBorins
commented
Aug 30, 2016
Contributor
@benjamingr hows it going :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
dns
Description of change
This is a more modular take on #5762 ,
Currently the DNS module imports isIP from both cares and
netanduses both of them both throughout the code base. This PR removes the
direct dependency
dnshas onnetand usesisIpfrom c-ares allthe time. Note that both functions do the same thing.