Skip to content

Benchmarks for sqlite - #58040

Closed
H4ad wants to merge 4 commits into
nodejs:mainfrom
H4ad:bench/sqlite
Closed

Benchmarks for sqlite#58040
H4ad wants to merge 4 commits into
nodejs:mainfrom
H4ad:bench/sqlite

Conversation

@H4ad

@H4adH4ad commented Apr 26, 2025

Copy link
Copy Markdown
Member

Add some benchmarks for sqlite module.

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 26, 2025
anonrig
anonrig requested changes Apr 26, 2025
View reviewed changes
Comment threadbenchmark/sqlite/sqlite-is-transaction.js Outdated
anonrig
anonrig reviewed Apr 26, 2025
View reviewed changes
Comment threadbenchmark/sqlite/sqlite-is-transaction.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-insert.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-select-all.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-select-all.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-select-get.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-select-get.js Outdated
Comment threadbenchmark/sqlite/sqlite-prepare-select-get.js Outdated
@H4ad
H4ad requested a review from anonrigApril 26, 2025 20:50
@H4adH4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 27, 2025
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 1, 2025
@nodejs-github-bot

nodejs-github-bot commented May 1, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/58040
✔ Done loading data for nodejs/node/pull/58040
----------------------------------- PR info ------------------------------------
Title Benchmarks for sqlite (#58040)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch H4ad:bench/sqlite -> nodejs:main
Labels benchmark, author ready, commit-queue-rebase, sqlite
Commits 4
- benchmark: add sqlite prepare insert
- benchmark: add sqlite is transaction
- benchmark: add sqlite prepare select all
- benchmark: add sqlite prepare select get
Committers 1
- Vinícius Lourenço <contact@viniciusl.com.br>
PR-URL: https://github.com/nodejs/node/pull/58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 26 Apr 2025 18:33:17 GMT
✔ Approvals: 1
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58040#pullrequestreview-2796455233
✘ This PR needs to wait 44 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14784515368

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@nodejs-github-bot

nodejs-github-bot commented May 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66538/

@nodejs-github-bot

nodejs-github-bot commented May 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66542/

@geeksilva97geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 2, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2025
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@H4ad@RafaelGSS
benchmark: add sqlite prepare insert
7a45f61
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@H4ad@RafaelGSS
benchmark: add sqlite is transaction
b06ed4b
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@H4ad@RafaelGSS
benchmark: add sqlite prepare select all
031b9bb
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@H4ad@RafaelGSS
benchmark: add sqlite prepare select get
b28263b
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@H4ad@aduh95
benchmark: add sqlite prepare insert
e4460f6
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@H4ad@aduh95
benchmark: add sqlite is transaction
f1c0193
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select all
52f5e37
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select get
258ac2e
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@H4ad@aduh95
benchmark: add sqlite prepare insert
0ca261e
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@H4ad@aduh95
benchmark: add sqlite is transaction
12dd7cb
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select all
0d71c91
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select get
ca0cd67
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@H4ad@aduh95
benchmark: add sqlite prepare insert
2469eba
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@H4ad@aduh95
benchmark: add sqlite is transaction
51f85e0
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select all
d51e34d
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select get
c6a2b91
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@H4ad@aduh95
benchmark: add sqlite prepare insert
f689f98
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@H4ad@aduh95
benchmark: add sqlite is transaction
6a9b79e
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select all
8390276
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@H4ad@aduh95
benchmark: add sqlite prepare select get
3766992
PR-URL: #58040
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes
@cjihrigcjihrigAwaiting requested review from cjihrig

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.sqliteIssues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@H4ad@nodejs-github-bot@anonrig@geeksilva97@mcollina