Skip to content

src: remove unused detachArrayBuffer method - #58055

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/remove-unnecessary-buffer
Apr 29, 2025
Merged

src: remove unused detachArrayBuffer method#58055
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/remove-unnecessary-buffer

Conversation

@anonrig

@anonriganonrig commented Apr 27, 2025

Copy link
Copy Markdown
Member

Removes unused method

@anonrig
anonrig requested review from jasnell and mcollinaApril 27, 2025 19:52
@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 27, 2025
@anonrig
anonrig requested a review from ronagApril 27, 2025 19:54
@codecov

codecovBot commented Apr 27, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (e0cf8ae) to head (7e3003c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58055 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01% 
==========================================
Files 630 630 Lines 186393 186375 -18 Branches 36595 36592 -3 ==========================================
+ Hits 168103 168116 +13 + Misses 11090 11086 -4 + Partials 7200 7173 -27
Files with missing linesCoverage Δ
src/node_buffer.cc68.06% <ø> (+0.55%)⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66490/

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66492/

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66493/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 6876607 into nodejs:mainApr 29, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Landed in 6876607

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@anonrig@RafaelGSS
src: remove unused detachArrayBuffer method
a842a15
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@anonrig@RafaelGSS
src: remove unused detachArrayBuffer method
f7ab630
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
839afff
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
ac314da
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@anonrig@RafaelGSS
src: remove unused detachArrayBuffer method
7d352d5
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
a522e39
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
8772484
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
da23503
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@anonrig@aduh95
src: remove unused detachArrayBuffer method
18f5301
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@legendecaslegendecaslegendecas approved these changes
@mcollinamcollinaAwaiting requested review from mcollina
@ronagronagAwaiting requested review from ronag

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@jasnell@lpinca@legendecas