Uh oh!
There was an error while loading. Please reload this page.
benchmark: disambiguate filename and dirname read perf - #58056
Merged
nodejs-github-bot merged 1 commit intoApr 29, 2025
Conversation
nodejs-github-bot
commented
Apr 27, 2025
Collaborator
Review requested:
|
jasnell
approved these changes
Apr 27, 2025
anonrig
approved these changes
Apr 27, 2025
lpinca
approved these changes
Apr 28, 2025
legendecas
approved these changes
Apr 28, 2025
nodejs-github-bot
commented
Apr 29, 2025
Collaborator
Landed in 99c2c90 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 6, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 6, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 17, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 18, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 19, 2025
PR-URL: #58056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #57286. Can be useful to measure them separately to get more fine-grained results when working on lazyloading them.