Uh oh!
There was an error while loading. Please reload this page.
buffer: add fast api for isAscii & isUtf8 - #58058
Open
anonrig wants to merge 4 commits into
Open
Conversation
anonrigforce-pushed
the
yagiz/add-fast-api-isascii
branch
from
April 28, 2025 01:23
6bb4020 to
8432a57CompareUh oh!
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #58058 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 630 630 Lines 186473 186496 +23 Branches 36613 36614 +1 ==========================================
+ Hits 168160 168162 +2 - Misses 11128 11132 +4 - Partials 7185 7202 +17
🚀 New features to boost your workflow:
|
ronag
approved these changes
Apr 28, 2025
anonrigforce-pushed
the
yagiz/add-fast-api-isascii
branch
2 times, most recently
from
April 29, 2025 17:00
2841143 to
ab8d328CompareUh oh!
There was an error while loading. Please reload this page.
anonrigforce-pushed
the
yagiz/add-fast-api-isascii
branch
from
May 3, 2025 16:24
ab8d328 to
d7ffbedCompareanonrig
requested review from
Renegade334, addaleax and mcollina
and removed request for
Renegade334May 3, 2025 16:24
anonrigforce-pushed
the
yagiz/add-fast-api-isascii
branch
from
May 3, 2025 16:25
d7ffbed to
54410b2Compareanonrigforce-pushed
the
yagiz/add-fast-api-isascii
branch
from
May 3, 2025 16:26
54410b2 to
7e84063Compareanonrig
commented
May 3, 2025
MemberAuthor
@jasnell@Renegade334 can you review this pull-request one more time? |
ronag
approved these changes
May 3, 2025
nodejs-github-bot
commented
May 3, 2025
Collaborator
jasnell
reviewed
May 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
May 7, 2025
jasnell
approved these changes
May 7, 2025
nodejs-github-bot
commented
May 7, 2025
Collaborator
juanarbol
approved these changes
May 7, 2025
nodejs-github-bot
commented
May 9, 2025
Collaborator
nodejs-github-bot
commented
Jun 26, 2025
Collaborator
H4ad
approved these changes
Jun 26, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 29, 2025
Collaborator
jasnell
commented
Jun 29, 2025
Member
The failure in CI here is not a flaky failure. It's relevant to the change being made here. That should be fixed before trying CI again. |
Ethan-Arrowood
approved these changes
Jun 30, 2025
slagiewka
commented
Jul 8, 2026
Looks like this was covered and released in #64169. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds v8 fast api for IsUtf8 and IsAscii methods
isAscii benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1706/
isUtf8 benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1708/