module: handle instantiated async module jobs in require(esm) by joyeecheung · Pull Request #58067 · nodejs/node

joyeecheung · 2025-04-29T00:39:29Z

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187.

Fixes: #58061

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in nodejs#57187.

nodejs-github-bot · 2025-04-29T00:39:34Z

Review requested:

@nodejs/loaders
@nodejs/vm

codecov · 2025-04-29T01:33:37Z

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (53abd1a) to head (da4207a).
Report is 117 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/modules/esm/module_job.js	79.41%	7 Missing ⚠️
src/module_wrap.cc	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #58067 +/- ##
=======================================
Coverage 90.20% 90.21% =======================================
Files 630 630 Lines 186391 186423 +32 Branches 36612 36615 +3 =======================================
+ Hits 168134 168177 +43 + Misses 11068 11061 -7 + Partials 7189 7185 -4

Files with missing lines	Coverage Δ
lib/internal/modules/esm/loader.js	`96.07% <100.00%> (+1.02%)`	⬆️
src/debug_utils.h	`80.00% <ø> (ø)`
src/module_wrap.h	`0.00% <ø> (ø)`
src/module_wrap.cc	`72.38% <87.50%> (+0.02%)`	⬆️
lib/internal/modules/esm/module_job.js	`97.12% <79.41%> (-1.15%)`	⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JakobJingleheimer

LGTM

nodejs-github-bot · 2025-04-30T13:40:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66514/

nodejs-github-bot · 2025-05-04T16:42:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66586/

nodejs-github-bot · 2025-05-05T10:51:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66609/

nodejs-github-bot · 2025-05-05T16:40:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/58067
✔ Done loading data for nodejs/node/pull/58067
----------------------------------- PR info ------------------------------------
Title module: handle instantiated async module jobs in require(esm) (#58067)
Author Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung)
Branch joyeecheung:fix-instantiated -> nodejs:main
Labels c++, lib / src, needs-ci
Commits 1
- module: handle instantiated async module jobs in require(esm)
Committers 1
- Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58067
Fixes: https://github.com/nodejs/node/issues/58061
Reviewed-By: Jacob Smith <jacob@frende.me>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58067
Fixes: https://github.com/nodejs/node/issues/58061
Reviewed-By: Jacob Smith <jacob@frende.me>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 29 Apr 2025 00:39:29 GMT
✔ Approvals: 1
✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/58067#pullrequestreview-2802523383
✘ This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-05-05T10:51:08Z: https://ci.nodejs.org/job/node-test-pull-request/66609/
- Querying data for job/node-test-pull-request/66609/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14841472093

nodejs-github-bot · 2025-05-08T20:10:35Z

Landed in e0766f9

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187. PR-URL: #58067Fixes: #58061 Reviewed-By: Jacob Smith <jacob@frende.me>

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in nodejs#57187. PR-URL: nodejs#58067Fixes: nodejs#58061 Reviewed-By: Jacob Smith <jacob@frende.me>

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187. PR-URL: #58067 Backport-PR-URL: #59504Fixes: #58061 Reviewed-By: Jacob Smith <jacob@frende.me> Refs: #52697

module: handle instantiated async module jobs in require(esm)
da4207a
When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in nodejs#57187.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2025

joyeecheung mentioned this pull request Apr 29, 2025
[Bug] Cannot import mjs from cjs if this mjs file is already planned to be imported (ReferenceError: default is not defined) #58061
Closed

JakobJingleheimer approved these changes Apr 29, 2025
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 5, 2025

joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 8, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2025

nodejs-github-bot merged commit e0766f9 into nodejs:mainMay 8, 2025

github-actionsBot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged

github-actionsBot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged

joyeecheung mentioned this pull request Jun 16, 2025
Tracking issue: require(esm) #52697
Closed
9 tasks

joyeecheung mentioned this pull request Aug 17, 2025
[v20.x] backport require(esm) bugfixes and improvements #59504
Closed

marco-ippolito mentioned this pull request Aug 20, 2025
2025-09-03, Version 20.19.5 'Iron' (LTS) #59551
Merged

Navigation Menu

Uh oh!

Uh oh!

module: handle instantiated async module jobs in require(esm) - #58067

module: handle instantiated async module jobs in require(esm)#58067
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-instantiated

joyeecheung commented Apr 29, 2025

Uh oh!

nodejs-github-bot commented Apr 29, 2025

Uh oh!

codecovBot commented Apr 29, 2025•
edited
Loading

Uh oh!

JakobJingleheimer left a comment

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented May 4, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

joyeecheung commented Apr 29, 2025

Uh oh!

nodejs-github-bot commented Apr 29, 2025

Uh oh!

codecovBot commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 30, 2025

Uh oh!

nodejs-github-bot commented May 4, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecovBot commented Apr 29, 2025•
edited
Loading