Skip to content

crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL - #58103

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:no-sec-level
May 12, 2025
Merged

crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL#58103
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:no-sec-level

Conversation

@codebytere

@codebyterecodebytere commented May 1, 2025•
edited
Loading

Copy link
Copy Markdown
Member

OPENSSL_TLS_SECURITY_LEVEL isn't defined at all in BoringSSL and will cause compilation failures.

Ref #57323
Ref #56601

See boringssl search results

@codebytere
codebytere requested a review from jasnellMay 1, 2025 17:51
@nodejs-github-bot

nodejs-github-bot commented May 1, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 1, 2025
@codebytere
codebytere requested a review from mhdawsonMay 1, 2025 17:52
mhdawson
mhdawson approved these changes May 1, 2025
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@codebyterecodebytere mentioned this pull request May 2, 2025
Merged
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2025
@nodejs-github-bot

nodejs-github-bot commented May 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66544/

@tniessen

tniessen commented May 2, 2025

Copy link
Copy Markdown
Member

FWIW, the default value is only 1 for OpenSSL < 3.2. On systems that compile and link against OpenSSL >= 3.2, the default value is already 2. That being said, I assume BoringSSL is still targeting OpenSSL 1.0.2/1.1.0/1.1.1 instead of 3.x, so assuming the pre-3.2 default seems reasonable.

@nodejs-github-bot

nodejs-github-bot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66621/

@nodejs-github-bot

nodejs-github-bot commented May 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66766/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f56590e into nodejs:mainMay 12, 2025
@nodejs-github-bot

nodejs-github-bot commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in f56590e

targos pushed a commit that referenced this pull request May 16, 2025
@codebytere@targos
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
a896eff
PR-URL: #58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 20, 2025
Merged
@aduh95aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Jun 10, 2025
@aduh95

aduh95 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

This does not land cleanly on v22.x-staging

npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
41d3814
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
a836bcd
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 25, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
461776b
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 25, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
366ebd3
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 25, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
b857982
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 26, 2025
@codebytere@npaun
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
8c83332
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
anonrig pushed a commit to nodejs/ncrypto that referenced this pull request Sep 26, 2025
@codebytere@anonrig
crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL
621d187
PR-URL: nodejs/node#58103
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-requested-v22.xPRs awaiting manual backport to the v22.x-staging branch.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@codebytere@nodejs-github-bot@tniessen@aduh95@jasnell@lpinca@mhdawson@RafaelGSS@richardlau