sqlite: add build option to build without sqlite by mhdawson · Pull Request #58122 · nodejs/node

mhdawson · 2025-05-02T16:18:59Z

Distributors of Node.js may want to ship without all of surface area so in some cases
build time options are provided to to that.

I was asked by the RHEL team to add an option to build without sqlite so that have that
flexibility and this PR does that.

Signed-off-by: Michael Dawson <midawson@redhat.com>

nodejs-github-bot · 2025-05-02T16:19:05Z

Signed-off-by: Michael Dawson <midawson@redhat.com>

anonrig · 2025-05-02T16:26:00Z

 hasIntl,
 hasCrypto,
 hasQuic,
+ hasSQLite,


Can we move the declaration here?

@anonrig can you clarify what you mean on this one?

Instead of having the variable declaration on top of the file, what about:
Suggested change
hasSQLite,
hasSQLite: Boolean(...),

That is not consistent with how any of the other ones are done as far as I can see. I was just trying to follow what seems to be existing practice.

codecov · 2025-05-02T17:16:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (53abd1a) to head (65e8818).
Report is 109 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58122 +/- ##
==========================================
- Coverage 90.20% 90.14% -0.07% 
==========================================
Files 630 630 Lines 186391 186784 +393 Branches 36612 36651 +39 ==========================================
+ Hits 168134 168369 +235 - Misses 11068 11199 +131 - Partials 7189 7216 +27

Files with missing lines	Coverage Δ
src/node_binding.cc	`82.67% <ø> (ø)`
src/node_builtins.cc	`79.17% <100.00%> (-0.49%)`	⬇️
src/node_metadata.cc	`91.52% <ø> (ø)`

... and 65 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Michael Dawson <midawson@redhat.com>

mhdawson · 2025-05-02T18:08:48Z

@anonrig addressed all of your comments except the one I asked for clarification on .

nodejs-github-bot · 2025-05-03T17:20:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66568/

nodejs-github-bot · 2025-05-05T16:11:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66617/

nodejs-github-bot · 2025-05-05T17:54:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66622/

Signed-off-by: Michael Dawson <midawson@redhat.com>

nodejs-github-bot · 2025-05-06T18:37:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66651/

nodejs-github-bot · 2025-05-06T20:18:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66656/

nodejs-github-bot · 2025-05-06T20:23:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66657/

Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #58122 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

mhdawson · 2025-05-07T21:21:55Z

Landed in 535c2f7

Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #58122 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#58122

nodejs/node#58122 Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#58122 Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#58122

sqlite: add build option to build without sqlite
1e54ab5
Signed-off-by: Michael Dawson <midawson@redhat.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 2, 2025

squash: address format-cpp failure
c7f67b4
Signed-off-by: Michael Dawson <midawson@redhat.com>

anonrig reviewed May 2, 2025
View reviewed changes

squash: address comments
cf26263
Signed-off-by: Michael Dawson <midawson@redhat.com>

geeksilva97 reviewed May 2, 2025
View reviewed changes

Comment threadsrc/node_builtins.cc

geeksilva97 approved these changes May 2, 2025
View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2025

RafaelGSS approved these changes May 5, 2025
View reviewed changes

aduh95 reviewed May 6, 2025
View reviewed changes

Comment threadMakefile Outdated

squash: address review comments
65e8818
Signed-off-by: Michael Dawson <midawson@redhat.com>

jasnell approved these changes May 7, 2025
View reviewed changes

geeksilva97 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2025

mhdawson added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 7, 2025

mhdawson closed this May 7, 2025

LiviaMedeiros mentioned this pull request May 9, 2025
test: fix executable flags #58250
Merged

github-actionsBot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged

RaisinTen mentioned this pull request Jun 6, 2025
test: account for truthy signal in flaky async_hooks tests #58478
Merged

github-actionsBot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged

codebytere added a commit to electron/electron that referenced this pull request Jul 10, 2025
fix: missing SQLite builtin support in Node.js
5080967
nodejs/node#58122

This was referenced Jul 10, 2025
build: fix node_use_sqlite for GN builds #59017
Merged
fix: missing SQLite builtin support in Node.js electron/electron#47706
Merged

codebytere added a commit to electron/electron that referenced this pull request Jul 11, 2025
fix: missing SQLite builtin support in Node.js
0df524d
nodejs/node#58122

codebytere added a commit to electron/electron that referenced this pull request Jul 11, 2025
fix: missing SQLite builtin support in Node.js
315ea70
nodejs/node#58122

codebytere added a commit to electron/electron that referenced this pull request Jul 14, 2025
fix: missing SQLite builtin support in Node.js
14f1685
nodejs/node#58122

codebytere added a commit to electron/electron that referenced this pull request Jul 15, 2025
fix: missing SQLite builtin support in Node.js (#47706)
17dba93
nodejs/node#58122

tropBot added a commit to electron/electron that referenced this pull request Jul 15, 2025
fix: missing SQLite builtin support in Node.js
a0b6bfd
nodejs/node#58122 Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

tropBot added a commit to electron/electron that referenced this pull request Jul 15, 2025
fix: missing SQLite builtin support in Node.js
fb4e3ef
nodejs/node#58122 Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

tropBot added a commit to electron/electron that referenced this pull request Jul 15, 2025
fix: missing SQLite builtin support in Node.js
8893caf
nodejs/node#58122 Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

georgexu99 pushed a commit to electron/electron that referenced this pull request Jul 16, 2025
fix: missing SQLite builtin support in Node.js (#47706)
0328255
nodejs/node#58122

kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
fix: missing SQLite builtin support in Node.js (electron#47706)
60a18aa
nodejs/node#58122

Uh oh!

Uh oh!

Conversation

mhdawson commented May 2, 2025

Uh oh!

nodejs-github-bot commented May 2, 2025

Uh oh!

Uh oh!

anonrigMay 2, 2025

Choose a reason for hiding this comment

Uh oh!

mhdawsonMay 2, 2025

Choose a reason for hiding this comment

Uh oh!

anonrigMay 2, 2025

Choose a reason for hiding this comment

Uh oh!

mhdawsonMay 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecovBot commented May 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mhdawson commented May 2, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 3, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 6, 2025

Uh oh!

nodejs-github-bot commented May 6, 2025

Uh oh!

nodejs-github-bot commented May 6, 2025

Uh oh!

mhdawson commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented May 2, 2025•
edited
Loading