Uh oh!
There was an error while loading. Please reload this page.
Add SourceMap Benchmark - #58125
Conversation
nodejs-github-bot
commented
May 2, 2025
Review requested:
|
5e438af to
4147ff3Comparemiguelmarcondesf
commented
May 3, 2025
anonrig
commented
May 3, 2025
You need to add a test for these benchmarks. You can find similar ones in test folder. |
miguelmarcondesf
commented
May 4, 2025
Thank you, just pushed that! |
5749fce to
bc9fbe9CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58125 +/- ##
==========================================
+ Coverage 90.07% 90.09% +0.02%
==========================================
Files 640 640 Lines 188262 188262 Branches 36912 36911 -1 ==========================================
+ Hits 169580 169623 +43 + Misses 11399 11363 -36 + Partials 7283 7276 -7 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f1040cd to
421ae12CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
legendecas
left a comment
There was a problem hiding this comment.
Thank you for the change! Overall LGTM % nits.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
02b5acc to
7eab302CompareUh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 20, 2025
c7232d1 to
ac7a40eComparenodejs-github-bot
commented
Jul 1, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58125 ✔ Done loading data for nodejs/node/pull/58125 ----------------------------------- PR info ------------------------------------ Title Add SourceMap Benchmark (#58125) Author Miguel Marcondes Filho <miguelmarcondesfilho@gmail.com> (@miguelmarcondesf) Branch miguelmarcondesf:performance-improvements-sourcemap -> nodejs:main Labels author ready, needs-ci, commit-queue-squash Commits 3 - benchmark: add source map and source map cache - benchmark: use fixtures for sourcemap cache - benchmark: use fixtures and avoid dead code for sourcemap Committers 1 - Miguel Marcondes <miguelmarcondesfilho@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 02 May 2025 17:48:50 GMT ✔ Approvals: 4 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2946108239 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/58125#pullrequestreview-2950130654 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2952013937 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58125#pullrequestreview-2975274650 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-23T13:44:33Z: https://ci.nodejs.org/job/node-test-pull-request/67620/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - benchmark: add source map and source map cache ⚠ - benchmark: use fixtures for sourcemap cache ⚠ - benchmark: use fixtures and avoid dead code for sourcemap - Querying data for job/node-test-pull-request/67620/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15999945215 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jul 7, 2025
nodejs-github-bot
commented
Jul 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 7, 2025
Landed in 9c025a9 |
PR-URL: #58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #58125 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Add SourceMap Benchmark
This PR introduces a new benchmark suite for the
lib/internal/source_mapmodule to help evaluate and explore the performance characteristics of theSourceMap.I'm still learning how everything fits together, but this is a first step toward understanding where small improvements could improve performance.
cc @BridgeAR