Skip to content

test: skip test-buffer-tostring-rangeerror when low on memory - #58142

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
BridgeAR:skip-flaky-buffer-rangeerror-when-low-on-memory
May 7, 2025
Merged

test: skip test-buffer-tostring-rangeerror when low on memory#58142
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
BridgeAR:skip-flaky-buffer-rangeerror-when-low-on-memory

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low.

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/33969/RUN_SUBSET=2,nodes=win2019-COMPILED_BY-vs2019/console

13:36:31 not ok 105 parallel/test-buffer-tostring-rangeerror
13:36:31 ---
13:36:31 duration_ms: 263.03700
13:36:31 severity: fail
13:36:31 exitcode: 1
13:36:31 stack: |-
13:36:31 node:assert:377
13:36:31 throw err;
13:36:31 ^
13:36:31 13:36:31 AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
13:36:31 + actual - expected
13:36:31 13:36:31 Comparison {
13:36:31 + name: 'RangeError'
13:36:31 - code: 'ERR_STRING_TOO_LONG',
13:36:31 - name: 'Error'
13:36:31 }
13:36:31 at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:8)
13:36:31 at Module._compile (node:internal/modules/cjs/loader:1529:14)
13:36:31 at Module._extensions..js (node:internal/modules/cjs/loader:1613:10)
13:36:31 at Module.load (node:internal/modules/cjs/loader:1275:32)
13:36:31 at Module._load (node:internal/modules/cjs/loader:1096:12)
13:36:31 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:164:12)
13:36:31 at node:internal/main/run_main_module:28:49 {
13:36:31 generatedMessage: true,
13:36:31 code: 'ERR_ASSERTION',
13:36:31 actual: RangeError: Array buffer allocation failed
13:36:31 at new ArrayBuffer (<anonymous>)
13:36:31 at new Uint8Array (<anonymous>)
13:36:31 at new FastBuffer (node:internal/buffer:961:5)
13:36:31 at Function.alloc (node:buffer:397:10)
13:36:31 at Buffer (node:buffer:275:19)
13:36:31 at C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:21
13:36:31 at getActual (node:assert:498:5)
13:36:31 at Function.throws (node:assert:644:24)
13:36:31 at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:8)
13:36:31 at Module._compile (node:internal/modules/cjs/loader:1529:14),
13:36:31 expected: { code: 'ERR_STRING_TOO_LONG', name: 'Error' },
13:36:31 operator: 'throws'
13:36:31 }
13:36:31 13:36:31 Node.js v20.19.2-pre
13:36:31 ...

This has shown up as RangeError: Array buffer allocation failed and
it should be totally fine to skip this test in case the memory is low.
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 3, 2025
@BridgeARBridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2025
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2025
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ No approving reviews found
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14813004228

@codecov

codecovBot commented May 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (f89baf2) to head (6f18c3c).
Report is 195 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58142 +/- ##
==========================================
- Coverage 90.24% 90.17% -0.08% 
==========================================
Files 630 630 Lines 185670 186473 +803 Branches 36401 36609 +208 ==========================================
+ Hits 167567 168154 +587 - Misses 10992 11119 +127 - Partials 7111 7200 +89 

see 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeirosLiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 4, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@BridgeARBridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 5f252a4 into nodejs:mainMay 7, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 5f252a4

targos pushed a commit that referenced this pull request May 16, 2025
This has shown up as RangeError: Array buffer allocation failed and
it should be totally fine to skip this test in case the memory is low.
PR-URL: #58142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
This has shown up as RangeError: Array buffer allocation failed and
it should be totally fine to skip this test in case the memory is low.
PR-URL: #58142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@BridgeAR@nodejs-github-bot@jasnell@lpinca@targos@StefanStojanovic@LiviaMedeiros