Uh oh!
There was an error while loading. Please reload this page.
deps: update llhttp to 9.3.0 - #58144
Merged
Merged
Conversation
nodejs-github-bot
commented
May 3, 2025
Collaborator
Review requested:
|
indutny
commented
May 3, 2025
MemberAuthor
cc @nodejs/http @nodejs/llhttp |
RafaelGSS
approved these changes
May 3, 2025
juanarbol
approved these changes
May 3, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58144 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 630 630 Lines 186473 186473 Branches 36613 36614 +1 ==========================================
- Hits 168160 168151 -9 + Misses 11128 11121 -7 - Partials 7185 7201 +16
🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
May 4, 2025
mcollina
commented
May 5, 2025
Member
Marked as dont-land-on-v20.x because it has llhttp v8. |
nodejs-github-bot
commented
May 5, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/58144 ✔ Done loading data for nodejs/node/pull/58144 ----------------------------------- PR info ------------------------------------ Title deps: update llhttp to 9.3.0 (#58144) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch indutny:feature/llhttp-9-3-0 -> nodejs:main Labels lib / src, needs-ci, dont-land-on-v20.x Commits 1 - deps: update llhttp to 9.3.0 Committers 1 - Fedor Indutny <238531+indutny@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 03 May 2025 17:49:33 GMT ✔ Approvals: 4 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813280324 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813281787 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813479866 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813582968 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14842769407 |
nodejs-github-bot
commented
May 6, 2025
Collaborator
nodejs-github-bot
commented
May 6, 2025
Collaborator
nodejs-github-bot
commented
May 6, 2025
Collaborator
nodejs-github-bot
commented
May 7, 2025
Collaborator
Landed in 4454d09 |
targos pushed a commit
that referenced
this pull request
May 16, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jun 5, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jun 5, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
aduh95 pushed a commit
that referenced
this pull request
Jun 10, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 14, 2025
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).