deps: enable new JS features the V8 way by targos · Pull Request #58230 · nodejs/node

targos · 2025-05-08T09:37:34Z

deps: patch V8 to 13.6.233.10
deps: V8: cherry-pick 044b9b6f589d
deps: V8: cherry-pick 4f38995c8295
deps: V8: backport 1d3362c55396
src: remove unneeded explicit V8 flags

Refs: v8/v8@13.6.233.8...13.6.233.10

Original commit message: [explicit-resource-management] disallow using in switch cases This CL disallows `using` and `await using` in switch cases. This was a normative change that got consensus in TC39 meetings: rbuckton/ecma262#14 Bug: 409478039 Change-Id: I077e75d7d0d632c8b34150cfc76e4903984d6091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6500234 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100037} Refs: v8/v8@044b9b6

Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995

Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot · 2025-05-08T09:37:39Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/startup
@nodejs/v8-update

targos · 2025-05-08T11:41:34Z

@gurgunday A PR is not author-ready until CI is started (when CI is needed): https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#author-ready-pull-requests

nodejs-github-bot · 2025-05-08T11:45:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66710/

codecov · 2025-05-08T12:01:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (535c2f7) to head (fa6d943).
Report is 22 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58230 +/- ##
==========================================
+ Coverage 90.12% 90.13% +0.01% 
==========================================
Files 629 629 Lines 186638 186636 -2 Branches 36618 36624 +6 ==========================================
+ Hits 168202 168224 +22 + Misses 11222 11209 -13 + Partials 7214 7203 -11

Files with missing lines	Coverage Δ
src/node.cc	`73.27% <ø> (-0.08%)`	⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-05-09T05:20:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66725/

nodejs-github-bot · 2025-05-10T09:39:37Z

Landed in 942862f...578a893

Refs: v8/v8@13.6.233.8...13.6.233.10 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] disallow using in switch cases This CL disallows `using` and `await using` in switch cases. This was a normative change that got consensus in TC39 meetings: rbuckton/ecma262#14 Bug: 409478039 Change-Id: I077e75d7d0d632c8b34150cfc76e4903984d6091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6500234 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100037} Refs: v8/v8@044b9b6 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Refs: v8/v8@13.6.233.8...13.6.233.10 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] disallow using in switch cases This CL disallows `using` and `await using` in switch cases. This was a normative change that got consensus in TC39 meetings: rbuckton/ecma262#14 Bug: 409478039 Change-Id: I077e75d7d0d632c8b34150cfc76e4903984d6091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6500234 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100037} Refs: v8/v8@044b9b6 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] disallow using in switch cases This CL disallows `using` and `await using` in switch cases. This was a normative change that got consensus in TC39 meetings: rbuckton/ecma262#14 Bug: 409478039 Change-Id: I077e75d7d0d632c8b34150cfc76e4903984d6091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6500234 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100037} Refs: v8/v8@044b9b6 PR-URL: nodejs#58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995 PR-URL: nodejs#58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [explicit-resource-management] disallow using in switch cases This CL disallows `using` and `await using` in switch cases. This was a normative change that got consensus in TC39 meetings: rbuckton/ecma262#14 Bug: 409478039 Change-Id: I077e75d7d0d632c8b34150cfc76e4903984d6091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6500234 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#100037} Refs: v8/v8@044b9b6 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> PR-URL: #58064 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995 PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> PR-URL: #58064 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> PR-URL: #58064 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targosand others added 5 commits May 8, 2025 10:50

deps: patch V8 to 13.6.233.10
e3c1960
Refs: v8/v8@13.6.233.8...13.6.233.10

src: remove unneeded explicit V8 flags
fa6d943

targos added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 8, 2025

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 8, 2025

targos added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 8, 2025

joyeecheung approved these changes May 8, 2025
View reviewed changes

gurgunday approved these changes May 8, 2025
View reviewed changes

gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2025

targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2025

richardlau approved these changes May 8, 2025
View reviewed changes

cjihrig approved these changes May 8, 2025
View reviewed changes

marco-ippolito approved these changes May 8, 2025
View reviewed changes

juanarbol approved these changes May 9, 2025
View reviewed changes

legendecas approved these changes May 9, 2025
View reviewed changes

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025

nodejs-github-bot closed this May 10, 2025

targos deleted the v8-patch-feat branch May 10, 2025 11:25

github-actionsBot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged

Navigation Menu

Uh oh!

Uh oh!

deps: enable new JS features the V8 way - #58230

deps: enable new JS features the V8 way#58230
targos wants to merge 5 commits into
nodejs:mainfrom
targos:v8-patch-feat

targos commented May 8, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

targos commented May 8, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

codecovBot commented May 8, 2025•
edited
Loading

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

targos commented May 8, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

targos commented May 8, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

codecovBot commented May 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecovBot commented May 8, 2025•
edited
Loading