Skip to content

test: enable test-shadow-realm-* tests - #58232

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:main
Closed

test: enable test-shadow-realm-* tests#58232
targos wants to merge 1 commit into
nodejs:mainfrom
targos:main

Conversation

@targos

Copy link
Copy Markdown
Member

Closes: #52273

This is to check if the issue is fixed after the V8 update and #58047

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 8, 2025
@targos

Copy link
Copy Markdown
MemberAuthor

Ok, still broken:

 === release test-shadow-realm-gc ===
Path: parallel/test-shadow-realm-gc
Error: --- stderr ---
node:events:485
throw er; // Unhandled 'error' event
^
Error [ERR_WORKER_OUT_OF_MEMORY]: Worker terminated due to reaching memory limit: JS heap out of memory

@codecov

codecovBot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (535c2f7) to head (39d03ee).
Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58232 +/- ##
==========================================
+ Coverage 90.12% 90.13% +0.01% 
==========================================
Files 629 629 Lines 186638 186638 Branches 36618 36618 ==========================================
+ Hits 168202 168228 +26 + Misses 11222 11213 -9 + Partials 7214 7197 -17 

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky GC-related tests with V8 12.2

2 participants

@targos@nodejs-github-bot