Uh oh!
There was an error while loading. Please reload this page.
timers: fix lint from 4fe02e2 - #5825
Merged
Merged
Conversation
Fishrock123
commented
Mar 21, 2016
ContributorAuthor
MylesBorins
commented
Mar 21, 2016
Contributor
LGTM. should we run CI for posterity? |
Fishrock123
commented
Mar 21, 2016
ContributorAuthor
depends if you want to wait 5m or not |
Fishrock123
commented
Mar 21, 2016
ContributorAuthor
Here's a run anyway: https://ci.nodejs.org/job/node-test-pull-request/1996/ |
whitlockjc
commented
Mar 21, 2016
Contributor
I was just about to tell you that I tested locally and that CI wasn't necessary. Probably best to had ran it anyways. ;) |
Fixes: nodejs#5823 Refs: nodejs#5793 PR-URL: nodejs#5825 Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fishrock123force-pushed
the
fix-lint-timers
branch
from
March 21, 2016 16:37
dd3fa5c to
d3a7534CompareFishrock123
commented
Mar 21, 2016
ContributorAuthor
some machines have passed, landed in d3a7534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Description of change
Please provide a description of the change here.
Fixes: #5823
Refs: #5793