Skip to content

http2: add diagnostics channel 'http2.client.stream.start' - #58292

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.start
May 14, 2025
Merged

http2: add diagnostics channel 'http2.client.stream.start'#58292
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.start

Conversation

@RaisinTen

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 12, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (6184730) to head (79695a2).
Report is 32 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58292 +/- ##
=======================================
Coverage 90.18% 90.19% =======================================
Files 631 631 Lines 186690 186703 +13 Branches 36666 36663 -3 =======================================
+ Hits 168360 168388 +28 + Misses 11126 11125 -1 + Partials 7204 7190 -14 
Files with missing linesCoverage Δ
lib/internal/http2/core.js95.46% <100.00%> (+0.01%)⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RaisinTenRaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 13, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b197355 into nodejs:mainMay 14, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in b197355

@RaisinTen
RaisinTen deleted the http2-add-diagnostics-channel-http2.client.stream.start branch May 14, 2025 07:46
@RaisinTenRaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label May 15, 2025
targos pushed a commit that referenced this pull request May 16, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.diagnostics_channelIssues and PRs related to diagnostics channelhttp2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RaisinTen@nodejs-github-bot@jasnell@santigimeno