Skip to content

Test runner/revert/#56664 - #58320

Closed
pmarchini wants to merge 4 commits into
nodejs:mainfrom
pmarchini:test_runner/revert/#56664
Closed

Test runner/revert/#56664#58320
pmarchini wants to merge 4 commits into
nodejs:mainfrom
pmarchini:test_runner/revert/#56664

Conversation

@pmarchini

Copy link
Copy Markdown
Member

This PR is a follow-up to #58282!

cc @romainmenke (if the changes are okay with others, I'd say you could just cherry-pick them into your PR)

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 14, 2025
@pmarchini

Copy link
Copy Markdown
MemberAuthor

@jakecastelli, could I please ask you to take a look at the latest commit?

Comment threadtest/fixtures/test-runner/output/test-timeout-flag.js Outdated
Comment threadtest/fixtures/test-runner/output/test-timeout-flag.js Outdated
@codecov

codecovBot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (770be2c) to head (544df03).
Report is 24 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/test_runner/harness.js85.71%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #58320 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05% 
==========================================
Files 631 633 +2 Lines 186689 186793 +104 Branches 36663 36669 +6 ==========================================
+ Hits 168359 168564 +205 + Misses 11128 11030 -98 + Partials 7202 7199 -3 
Files with missing linesCoverage Δ
lib/internal/test_runner/test.js97.11% <100.00%> (-0.03%)⬇️
lib/internal/test_runner/harness.js93.13% <85.71%> (-0.22%)⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini
pmarchiniforce-pushed the test_runner/revert/#56664 branch from 7557818 to b7edccfCompareMay 14, 2025 13:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pmarchini@nodejs-github-bot@jakecastelli@romainmenke