Skip to content

benchmark: fix linting errors - #5840

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-5359-borkage
Closed

benchmark: fix linting errors#5840
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-5359-borkage

Conversation

@Trott

@TrottTrott commented Mar 22, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

benchmark

Description of change

4d78121 had lint errors that went
undetected. This fixes them.

@Trott
benchmark: fix linting errors
738777d
4d78121 had lint errors that went
undetected. This fixes them.
@TrottTrott added benchmark Issues and PRs related to the benchmark subsystem. lts-watch-v4.x labels Mar 22, 2016
@Trott

Trott commented Mar 22, 2016

Copy link
Copy Markdown
MemberAuthor

Since CI is broken until this lands, and these changes are tiny, a fast turnaround would be much appreciated. /cc @nodjes/collaborators

@evanlucas

evanlucas commented Mar 22, 2016

Copy link
Copy Markdown
Contributor

LGTM

@TrottTrott mentioned this pull request Mar 22, 2016
Closed
@MylesBorins

MylesBorins commented Mar 22, 2016

Copy link
Copy Markdown
Contributor

LGTM... tested locally

@jasnell

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

LGTM

@jasnell

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

Will get it landed

jasnell pushed a commit that referenced this pull request Mar 22, 2016
@Trott@jasnell
benchmark: fix linting errors
cde81b6
4d78121 had lint errors that went
undetected. This fixes them.
PR-URL: #5840
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

Landed in cde81b6

@jasnelljasnell closed this Mar 22, 2016
@Trott

Trott commented Mar 22, 2016

Copy link
Copy Markdown
MemberAuthor

Retroactive CI: https://ci.nodejs.org/job/node-test-pull-request/2008/

@jasnell

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

ran make lint on this before landing ;-)

@Trott

Trott commented Mar 22, 2016

Copy link
Copy Markdown
MemberAuthor

Linting passed at least: https://ci.nodejs.org/job/node-test-linter/1757/ :-P

@Trott

Trott commented Mar 22, 2016

Copy link
Copy Markdown
MemberAuthor

7 minutes from proposed to landed. This might be the fastest PR merge of the post-BDFL era.

@jasnell

jasnell commented Mar 22, 2016

Copy link
Copy Markdown
Member

heh... looks like I shouldn't land pull requests while distracted. I must have completely missed running make lint locally on several PRs in a row. More automation would be good. I need to get the PR landing tool finished up.

@Fishrock123Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
@Trott@Fishrock123
benchmark: fix linting errors
341b3d0
4d78121 had lint errors that went
undetected. This fixes them.
PR-URL: #5840
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott deleted the fix-5359-borkage branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@evanlucas@MylesBorins@jasnell