lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none" by danielmbrasil · Pull Request #58496 · nodejs/node

danielmbrasil · 2025-05-28T14:32:57Z

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

danielmbrasil · 2025-05-28T14:32:57Z

Fixes#57399.

nodejs-github-bot · 2025-05-28T14:33:03Z

Review requested:

@nodejs/test_runner

danielmbrasil · 2025-05-28T14:33:35Z

@@ -691,6 +691,17 @@ function run(options = kEmptyObject) {
 cwd,
 globalSetupPath,
 };
+
+ if (isolation === 'none') {


Not sure if it's a good approach. See my comment on the issue: #57399 (comment).

I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀

danielmbrasil · 2025-05-28T14:35:24Z

@@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
 });
 });

+describe("with isolation set to 'none'",() => {


Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.

I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)

Hey @pmarchini, sorry for the delay in getting back to this. I’ve followed your suggestion and got the tests working, thanks!

codecov · 2025-07-04T17:02:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (813b4e8) to head (db62068).
⚠️ Report is 3014 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58496 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 640 640 Lines 188442 188453 +11 Branches 36971 36975 +4 ==========================================
+ Hits 169735 169743 +8 - Misses 11424 11426 +2 - Partials 7283 7284 +1

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`93.25% <100.00%> (+0.54%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini · 2025-07-06T19:50:54Z

+ const testSkipPatterns = options.testSkipPatterns ? JSON.stringify(options.testSkipPatterns) : undefined;
+ const isolation = options.isolation ? JSON.stringify(options.isolation) : undefined;
+
+ const code = `


I would suggest moving this to a real fixture!

github-actions · 2026-07-28T00:24:09Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2025

danielmbrasil commented May 28, 2025
View reviewed changes

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9af076f to 9aeef6cCompare May 28, 2025 14:37

geeksilva97 requested review from cjihrig and pmarchini May 28, 2025 14:40

danielmbrasil added 2 commits July 4, 2025 13:07

lib: support testNamePatterns and testSkipPatterns with 'none' isolation
4c8e03d

test: fix tests
db62068

danielmbrasil force-pushed the fix/test-runner-ignore-patterns-isolation-none branch from 9aeef6c to db62068Compare July 4, 2025 16:08

danielmbrasil marked this pull request as ready for review July 4, 2025 16:13

pmarchini reviewed Jul 6, 2025
View reviewed changes

inukshuk mentioned this pull request Mar 15, 2026
test_runner: use run() options with isolation="none" #62269
Closed

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

danielmbrasil closed this Jul 28, 2026

Uh oh!

Uh oh!

Conversation

danielmbrasil commented May 28, 2025

Uh oh!

nodejs-github-bot commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Jul 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

danielmbrasil commented May 28, 2025

Uh oh!

nodejs-github-bot commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Jul 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

danielmbrasil commented May 28, 2025

Uh oh!

nodejs-github-bot commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

codecovBot commented Jul 4, 2025•
edited
Loading

codecovBot commented Jul 4, 2025•
edited
Loading

codecovBot commented Jul 4, 2025•
edited
Loading