Skip to content

test: remove duplicated allocUnsafeSlow test - #58524

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:test-rm-dup
Jun 2, 2025
Merged

test: remove duplicated allocUnsafeSlow test#58524
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:test-rm-dup

Conversation

@targos

@targostargos commented May 31, 2025

Copy link
Copy Markdown
Member

No description provided.

@targostargos added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 31, 2025
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 31, 2025
@codecov

codecovBot commented May 31, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (968e2f4) to head (67d595f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58524 +/- ##
==========================================
+ Coverage 90.21% 90.24% +0.02% 
==========================================
Files 635 635 Lines 187580 187580 Branches 36853 36862 +9 ==========================================
+ Hits 169231 169281 +50 + Misses 11108 11065 -43 + Partials 7241 7234 -7

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2025
@nodejs-github-bot

nodejs-github-bot commented May 31, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67203/

@nodejs-github-bot

nodejs-github-bot commented May 31, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67210/

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2025
@nodejs-github-bot
nodejs-github-bot merged commit eb159a8 into nodejs:mainJun 2, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

Landed in eb159a8

@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2025
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@jasnell@lpinca@anonrig@RaisinTen@bjohansebas