Skip to content

src: fix typo in CFunctionCallbackWithalueAndOptions declaration - #58545

Closed
dario-piotrowicz wants to merge 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/withalue-typo
Closed

src: fix typo in CFunctionCallbackWithalueAndOptions declaration#58545
dario-piotrowicz wants to merge 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/withalue-typo

Conversation

@dario-piotrowicz

@dario-piotrowiczdario-piotrowicz commented Jun 1, 2025

Copy link
Copy Markdown
Member

PS: I'm also addressing this in #58544, if that PR were to land I'll simply close this one

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 1, 2025
@codecov

codecovBot commented Jun 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (968e2f4) to head (69738ff).
Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58545 +/- ##
=======================================
Coverage 90.21% 90.22% =======================================
Files 635 635 Lines 187580 187580 Branches 36853 36855 +2 =======================================
+ Hits 169231 169245 +14 + Misses 11108 11106 -2 + Partials 7241 7229 -12 
Files with missing linesCoverage Δ
src/node_external_reference.h100.00% <ø> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz

Copy link
Copy Markdown
MemberAuthor

Closing in favous of #58544

(sorry @targos, thanks for reviewing the PR 🙇)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dario-piotrowicz@targos@nodejs-github-bot