Skip to content

test: fix flaky test-http-set-timeout - #5856

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:timeout-sadness
Closed

test: fix flaky test-http-set-timeout#5856
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:timeout-sadness

Conversation

@Trott

@TrottTrott commented Mar 23, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

Increase timeout on Raspberry Pi to alleviate flakiness.

Fixes: #5854

@Trott
test: fix flaky test-http-set-timeout
1fe65dd
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: nodejs#5854
@TrottTrott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. lts-watch-v4.x labels Mar 23, 2016
@Trott

Trott commented Mar 23, 2016

Copy link
Copy Markdown
MemberAuthor

Stress test that will hopefully show flakiness on master: https://ci.nodejs.org/job/node-stress-single-test/564/nodes=pi1-raspbian-wheezy/console

Stress test that will hopefully show no flakiness with this change: https://ci.nodejs.org/job/node-stress-single-test/565/nodes=pi1-raspbian-wheezy/console

(They've both been compiling for 2.5 hours...pi1 platform, whatcha gonna do, rite?)

@jasnell

jasnell commented Mar 23, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@cjihrig

cjihrig commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Trott commented Mar 23, 2016

Copy link
Copy Markdown
MemberAuthor

100 runs did not seem to be enough to get a flaky result on master. Trying 999.

master: https://ci.nodejs.org/job/node-stress-single-test/566/nodes=pi1-raspbian-wheezy/console

this branch: https://ci.nodejs.org/job/node-stress-single-test/567/nodes=pi1-raspbian-wheezy/console

@Trott

Trott commented Mar 24, 2016

Copy link
Copy Markdown
MemberAuthor

Stress test at 999 jobs still does not reproduce issue on master, but we have the one example and this would seem to be an improvement, so...

CI: https://ci.nodejs.org/job/node-test-pull-request/2060/

Trott added a commit to Trott/io.js that referenced this pull request Mar 24, 2016
@Trott
test: fix flaky test-http-set-timeout
04ac1c0
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: nodejs#5854
PR-URL: nodejs#5856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

Trott commented Mar 24, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 04ac1c0

@TrottTrott closed this Mar 24, 2016
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
@Trott@evanlucas
test: fix flaky test-http-set-timeout
ee8de3f
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: #5854
PR-URL: #5856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucasevanlucas mentioned this pull request Mar 31, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
@Trott@evanlucas
test: fix flaky test-http-set-timeout
fb0c5bc
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: #5854
PR-URL: #5856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 8, 2016
@TrottMyles Borins
test: fix flaky test-http-set-timeout
e0b283a
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: #5854
PR-URL: #5856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 11, 2016
Merged
@Trott
Trott deleted the timeout-sadness branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

armIssues and PRs related to the ARM architecture.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http-set-timeout

4 participants

@Trott@jasnell@cjihrig@MylesBorins