Skip to content

src: make global error message vectors const in contextify - #58580

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mertcanaltin:mert/refactor/contextify-memory-safety-perf
Jun 10, 2025
Merged

src: make global error message vectors const in contextify#58580
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mertcanaltin:mert/refactor/contextify-memory-safety-perf

Conversation

@mertcanaltin

@mertcanaltinmertcanaltin commented Jun 4, 2025•
edited
Loading

Copy link
Copy Markdown
Member

I converted esm_syntax_error_messages and throws_only_in_cjs_error_messages to const vector

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 4, 2025
@mertcanaltin
mertcanaltinforce-pushed the mert/refactor/contextify-memory-safety-perf branch from fd41107 to 71dd334CompareJune 4, 2025 21:38
@codecov

codecovBot commented Jun 4, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (641653b) to head (faf8ce9).
Report is 47 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58580 +/- ##
==========================================
- Coverage 90.21% 90.20% -0.02% 
==========================================
Files 635 635 Lines 187494 187511 +17 Branches 36838 36815 -23 ==========================================
- Hits 169144 169140 -4 - Misses 11145 11171 +26 + Partials 7205 7200 -5
Files with missing linesCoverage Δ
src/node_contextify.cc81.24% <ø> (-0.04%)⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67279/

addaleax
addaleax approved these changes Jun 5, 2025
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could even be std::array, right?

Comment threadsrc/node_contextify.cc Outdated
addaleax
addaleax approved these changes Jun 5, 2025
View reviewed changes
Comment threadsrc/node_contextify.cc Outdated
@mertcanaltin
mertcanaltinforce-pushed the mert/refactor/contextify-memory-safety-perf branch 5 times, most recently from 19a716c to 7be95faCompareJune 5, 2025 23:43
@mertcanaltin
mertcanaltinforce-pushed the mert/refactor/contextify-memory-safety-perf branch from 7be95fa to faf8ce9CompareJune 5, 2025 23:45
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67360/

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67371/

@addaleaxaddaleax mentioned this pull request Jun 9, 2025
Merged
@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 238af6a into nodejs:mainJun 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in 238af6a

seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@mertcanaltin@seriousme
src: replace std::array with static arrays in contextify
095cb3b
PR-URL: nodejs#58580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 16, 2025
@mertcanaltin@targos
src: replace std::array with static arrays in contextify
e9c6fa5
PR-URL: #58580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@mertcanaltin@aduh95
src: replace std::array with static arrays in contextify
2f9ed95
PR-URL: #58580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@mertcanaltin@aduh95
src: replace std::array with static arrays in contextify
daf65d4
PR-URL: #58580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@jasnelljasnelljasnell approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mertcanaltin@nodejs-github-bot@jasnell@addaleax@legendecas