Skip to content

build: remove config.status under make distclean - #58603

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:make-distclean-config-status
Jun 12, 2025
Merged

build: remove config.status under make distclean#58603
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:make-distclean-config-status

Conversation

@Renegade334

@Renegade334Renegade334 commented Jun 6, 2025

Copy link
Copy Markdown
Member

refs: #21371

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 6, 2025
@codecov

codecovBot commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (c1f090d) to head (d437db6).
Report is 52 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58603 +/- ##
==========================================
- Coverage 90.20% 89.69% -0.51% 
==========================================
Files 636 636 Lines 187698 187698 Branches 36852 36564 -288 ==========================================
- Hits 169316 168362 -954 - Misses 11165 12054 +889 - Partials 7217 7282 +65

see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334Renegade334 changed the title tools: remove config.status under make distcleanbuild: remove config.status under make distcleanJun 6, 2025
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67343/

@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67424/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 88cfdb3 into nodejs:mainJun 12, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in 88cfdb3

targos pushed a commit that referenced this pull request Jun 16, 2025
@Renegade334@targos
tools: remove config.status under make distclean
268c8c1
PR-URL: #58603
Refs: #21371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
@Renegade334
Renegade334 deleted the make-distclean-config-status branch July 16, 2025 23:08
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@Renegade334@aduh95
tools: remove config.status under make distclean
54cbf7d
PR-URL: #58603
Refs: #21371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@Renegade334@aduh95
tools: remove config.status under make distclean
9798511
PR-URL: #58603
Refs: #21371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Renegade334@nodejs-github-bot@lpinca@aduh95