Skip to content

doc: add path rules and validation for export targets in package.json - #58604

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
0hmX:58576_2
Jun 9, 2025
Merged

doc: add path rules and validation for export targets in package.json#58604
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
0hmX:58576_2

Conversation

@0hmX

@0hmX0hmX commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Close#58576

I have added a new section called # Path Rules and Validation for Export Targets that goes over the invalid paths that are possible & and their valid counter parts

@nodejs-github-bot

nodejs-github-bot commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 6, 2025
algoORgoal
algoORgoal reviewed Jun 7, 2025
View reviewed changes

@algoORgoalalgoORgoal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit describes what was missing perfectly. Thank you for your pull request :)

JakobJingleheimer
JakobJingleheimer approved these changes Jun 7, 2025
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Comment threaddoc/api/packages.md Outdated
Comment threaddoc/api/packages.md Outdated
@JakobJingleheimerJakobJingleheimer added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 7, 2025
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
aduh95
aduh95 reviewed Jun 7, 2025
View reviewed changes
Comment threaddoc/api/packages.md Outdated
@0hmX
0hmX requested a review from aduh95June 8, 2025 13:57
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 987aa0a into nodejs:mainJun 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in 987aa0a

seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@0hmX@seriousme
doc: add path rules and validation for export targets in package.json
e22c732
PR-URL: nodejs#58604
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jun 16, 2025
@0hmX@targos
doc: add path rules and validation for export targets in package.json
d596803
PR-URL: #58604
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@0hmX@aduh95
doc: add path rules and validation for export targets in package.json
9a819e0
PR-URL: #58604
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@0hmX@aduh95
doc: add path rules and validation for export targets in package.json
133b10a
PR-URL: #58604
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@aduh95aduh95aduh95 approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@algoORgoalalgoORgoalalgoORgoal left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify Invalid Path Segment Rules in exports Field Documentation

6 participants

@0hmX@nodejs-github-bot@JakobJingleheimer@aduh95@algoORgoal@marco-ippolito