module: convert schema-only core module on `convertCJSFilenameToURL` by himself65 · Pull Request #58612 · nodejs/node

himself65 · 2025-06-07T09:12:19Z

nodejs-github-bot · 2025-06-07T09:12:23Z

Review requested:

@nodejs/loaders

joyeecheung · 2025-06-07T09:18:00Z

From the issue description I don’t think its the validation that should be changed - it should be the URL that gets passed into the hooks that should be corrected (it should’ve been node:sea instead of sea, looks like somewhere in the CJS loader the conversion is missed since internally we use filenames and ids everywhere and only convert them to URLs when being passed into hooks).

codecov · 2025-06-07T10:44:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (faada65) to head (ee2dc06).
Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58612 +/- ##
=======================================
Coverage 90.09% 90.10% =======================================
Files 640 640 Lines 188271 188275 +4 Branches 36923 36923 =======================================
+ Hits 169625 169641 +16 + Misses 11386 11344 -42 - Partials 7260 7290 +30

Files with missing lines	Coverage Δ
lib/internal/modules/customization_hooks.js	`100.00% <100.00%> (ø)`

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

himself65 · 2025-06-07T10:57:47Z

From the issue description I don’t think its the validation that should be changed - it should be the URL that gets passed into the hooks that should be corrected (it should’ve been node:sea instead of sea, looks like somewhere in the CJS loader the conversion is missed since internally we use filenames and ids everywhere and only convert them to URLs when being passed into hooks).

Yeah, I read the code and think the issue should be in convertCJSFilenameToURL ? updated the code now

github-actions · 2025-06-09T18:59:00Z

Failed to start CI

 ⚠ No approving reviews found
✘ Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/15542291850

joyeecheung · 2025-06-15T13:55:44Z

#58612 (comment)@himself65 in case you missed it

nodejs-github-bot · 2025-06-19T20:52:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67545/

nodejs-github-bot · 2025-06-24T09:37:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67634/

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot · 2025-06-24T10:24:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67635/

nodejs-github-bot · 2025-06-24T11:43:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67636/

nodejs-github-bot · 2025-06-24T16:38:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67639/

nodejs-github-bot · 2025-06-25T11:40:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67648/

nodejs-github-bot · 2025-06-25T16:49:57Z

Landed in a705e24

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #58612Fixes: #58607 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jun 7, 2025

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 136b877 to 817052dCompare June 7, 2025 09:13

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 22850d8 to a49f57bCompare June 7, 2025 10:57

himself65 changed the title ~~module: skip check builtin module on validateLoad~~module: fix schema only core module on convertCJSFilenameToURLJun 7, 2025

himself65 changed the title ~~module: fix schema only core module on convertCJSFilenameToURL~~module: convert schema-only core module on convertCJSFilenameToURLJun 7, 2025

himself65 force-pushed the himself65/2025/06/07/custom-hook branch 3 times, most recently from 08ec6cc to d2b8035Compare June 7, 2025 11:33

joyeecheung reviewed Jun 9, 2025
View reviewed changes

Comment threadlib/internal/modules/customization_hooks.js Outdated

joyeecheung reviewed Jun 9, 2025
View reviewed changes

Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated
Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated
Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated
Comment threadlib/internal/modules/customization_hooks.js Outdated

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 2f30145 to 9bcd67aCompare June 9, 2025 16:10

joyeecheung reviewed Jun 9, 2025
View reviewed changes

Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2025

himself65 requested a review from joyeecheung June 11, 2025 16:02

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 1bec580 to a79df89Compare June 16, 2025 07:54

joyeecheung reviewed Jun 16, 2025
View reviewed changes

Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated
Comment threadtest/module-hooks/test-module-hooks-builtin-require.js Outdated

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 628e6d7 to 4b27d6aCompare June 16, 2025 16:14

joyeecheung approved these changes Jun 19, 2025
View reviewed changes

joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 19, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

module: convert schema-only core module on convertCJSFilenameToURL
ee2dc06
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

himself65 force-pushed the himself65/2025/06/07/custom-hook branch from 4b27d6a to ee2dc06Compare June 24, 2025 10:19

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2025

himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2025

nodejs-github-bot merged commit a705e24 into nodejs:mainJun 25, 2025
72 checks passed

targos pushed a commit that referenced this pull request Jul 3, 2025
module: convert schema-only core module on convertCJSFilenameToURL
a78385c
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #58612Fixes: #58607 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

github-actionsBot mentioned this pull request Jul 8, 2025
2025-07-09, Version 24.4.0 (Current) #58993
Merged

aduh95 pushed a commit that referenced this pull request Jul 21, 2025
module: convert schema-only core module on convertCJSFilenameToURL
c30168a
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #58612Fixes: #58607 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

aduh95 pushed a commit that referenced this pull request Jul 24, 2025
module: convert schema-only core module on convertCJSFilenameToURL
bfc68c8
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #58612Fixes: #58607 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

github-actionsBot mentioned this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256
Merged

samchon mentioned this pull request Jul 20, 2026
ttsx: preserve prefix-only node builtin URLs on affected Node releases samchon/ttsc#880
Closed

Uh oh!

Uh oh!

Conversation

himself65 commented Jun 7, 2025

Uh oh!

nodejs-github-bot commented Jun 7, 2025

Uh oh!

joyeecheung commented Jun 7, 2025

Uh oh!

codecovBot commented Jun 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

himself65 commented Jun 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Jun 9, 2025

Uh oh!

joyeecheung commented Jun 15, 2025

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 19, 2025

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

nodejs-github-bot commented Jun 25, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecovBot commented Jun 7, 2025•
edited
Loading