Skip to content

test: cleanup status files - #58633

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-clean-status
Jun 10, 2025
Merged

test: cleanup status files#58633
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-clean-status

Conversation

@panva

@panvapanva commented Jun 8, 2025

Copy link
Copy Markdown
Member
  • removes empty expectations from status files
  • aligns empty status file to be single-line json

@panvapanva added test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 8, 2025
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@github-actions

This comment was marked as outdated.

Sign in to view
@panvapanva removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jun 8, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67327/

@codecov

codecovBot commented Jun 8, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (3c351c2) to head (65de22a).
Report is 241 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58633 +/- ##
=======================================
Coverage 90.13% 90.13% =======================================
Files 636 636 Lines 187891 187891 Branches 36878 36878 =======================================
+ Hits 169348 169363 +15 - Misses 11289 11294 +5 + Partials 7254 7234 -20

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67329/

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit d0b6194 into nodejs:mainJun 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in d0b6194

@panva
panva deleted the wpt-clean-status branch June 10, 2025 14:01
seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@panva@seriousme
test: cleanup status files
a2e7476
PR-URL: nodejs#58633
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
targos pushed a commit that referenced this pull request Jun 16, 2025
@panva@targos
test: cleanup status files
181014a
PR-URL: #58633
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
@aduh95aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jul 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@legendecaslegendecaslegendecas approved these changes
@jazellyjazellyjazelly approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@panva@nodejs-github-bot@lpinca@legendecas@jazelly@KhafraDev@aduh95