Uh oh!
There was an error while loading. Please reload this page.
test: refactor repl tab complete tests - #58636
Merged
nodejs-github-bot merged 2 commits intoJun 15, 2025
Merged
Conversation
Comment on lines
56
to
61
MemberAuthor
There was a problem hiding this comment.
PS: this is the driving reason for this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58636 +/- ##
==========================================
- Coverage 90.16% 90.15% -0.02%
==========================================
Files 637 637 Lines 188001 188001 Branches 36881 36877 -4 ==========================================
- Hits 169509 169484 -25 - Misses 11238 11286 +48 + Partials 7254 7231 -23 🚀 New features to boost your workflow:
|
puskin
approved these changes
Jun 9, 2025
dario-piotrowiczforce-pushed
the
dario/repl-complete-tests-refactor
branch
from
June 9, 2025 09:05
ae1c33f to
ce45b2aCompareMemberAuthor
cc. @nodejs/repl would anyone like to have a look? 🙂 |
aduh95
reviewed
Jun 14, 2025
Uh oh!
There was an error while loading. Please reload this page.
refactor the test/parallel/test-repl-tab-complete.js file by: - making the tests in the file self-contained (instead of all of them sharing the same REPL instance and constantly calling `.clear` on it) - using the test runner with appropriate descriptions to make clearer what is being tested - extracting some tests in their own js test files (to increase isolation of the tests and help with issues such as flakiness)
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
dario-piotrowiczforce-pushed
the
dario/repl-complete-tests-refactor
branch
from
June 14, 2025 17:17
40bfac8 to
0d6cb84Comparejasnell
approved these changes
Jun 14, 2025
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 15, 2025
Collaborator
nodejs-github-bot
commented
Jun 15, 2025
Collaborator
Landed in aee9bc0 |
targos pushed a commit
that referenced
this pull request
Jun 16, 2025
refactor the test/parallel/test-repl-tab-complete.js file by: - making the tests in the file self-contained (instead of all of them sharing the same REPL instance and constantly calling `.clear` on it) - using the test runner with appropriate descriptions to make clearer what is being tested - extracting some tests in their own js test files (to increase isolation of the tests and help with issues such as flakiness) PR-URL: #58636 Reviewed-By: Giovanni Bucci <github@puskin.it> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jun 23, 2025
aduh95
commented
Jul 21, 2025
Contributor
This doesn't land cleanly on v22.x-staging, we'd need a backport PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor the test/parallel/test-repl-tab-complete.js file by:
.clearon it)