Skip to content

module: fix typescript import.meta.main - #58661

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-import-meta-main-typescript
Jun 12, 2025
Merged

module: fix typescript import.meta.main#58661
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-import-meta-main-typescript

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Jun 10, 2025

Copy link
Copy Markdown
Member

Fixes: #58660

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jun 10, 2025
@marco-ippolitomarco-ippolito added the strip-types Issues or PRs related to strip-types support label Jun 10, 2025
@codecov

codecovBot commented Jun 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (d0b6194) to head (206cb25).
Report is 19 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58661 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02% 
==========================================
Files 636 636 Lines 188030 188028 -2 Branches 36894 36892 -2 ==========================================
- Hits 169563 169538 -25 - Misses 11214 11232 +18 - Partials 7253 7258 +5
Files with missing linesCoverage Δ
lib/internal/modules/esm/translators.js92.28% <100.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meixgmeixg added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67380/

@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67382/

@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2025
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit bba07d7 into nodejs:mainJun 12, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in bba07d7

@alexsch01alexsch01 mentioned this pull request Jun 12, 2025
Merged
Lordfirespeed pushed a commit to Lordfirespeed/node that referenced this pull request Jun 13, 2025
@marco-ippolito@Lordfirespeed
module: fix typescript import.meta.main
d8d3b07
PR-URL: nodejs#58661Fixes: nodejs#58660
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
(cherry picked from commit bba07d7)
targos pushed a commit that referenced this pull request Jun 16, 2025
@marco-ippolito@targos
module: fix typescript import.meta.main
ff8a369
PR-URL: #58661Fixes: #58660
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit to Lordfirespeed/node that referenced this pull request Jul 28, 2025
@marco-ippolito@aduh95
module: fix typescript import.meta.main
2fc8989
PR-URL: nodejs#58661
Backport-PR-URL: nodejs#58693Fixes: nodejs#58660
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@meixgmeixgmeixg approved these changes
@aduh95aduh95aduh95 approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@pmarchinipmarchinipmarchini approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.strip-typesIssues or PRs related to strip-types support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(node:24): import meta main dont work

9 participants

@marco-ippolito@nodejs-github-bot@anonrig@JakobJingleheimer@meixg@aduh95@Ethan-Arrowood@pmarchini@atlowChemi